This is an archive of the discontinued LLVM Phabricator instance.

ELF: Don't dereference Repl in MarkLive. NFCI.
ClosedPublic

Authored by pcc on Jun 21 2017, 10:56 AM.

Reviewers

Commits

Summary

This is unnecessary because --gc-sections runs before ICF.

LGTM

This revision is now accepted and ready to land.Jun 21 2017, 2:21 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

lld/

trunk/

ELF/

2 lines

Show First 20 Lines • Show All 72 Lines • ▼ Show 20 Lines	static void resolveReloc(InputSectionBase &Sec, RelT &Rel,
std::function<void(ResolvedReloc)> Fn) {		std::function<void(ResolvedReloc)> Fn) {
SymbolBody &B = Sec.getFile<ELFT>()->getRelocTargetSym(Rel);		SymbolBody &B = Sec.getFile<ELFT>()->getRelocTargetSym(Rel);
if (auto *D = dyn_cast<DefinedRegular>(&B)) {		if (auto *D = dyn_cast<DefinedRegular>(&B)) {
if (!D->Section)		if (!D->Section)
return;		return;
typename ELFT::uint Offset = D->Value;		typename ELFT::uint Offset = D->Value;
if (D->isSection())		if (D->isSection())
Offset += getAddend<ELFT>(Sec, Rel);		Offset += getAddend<ELFT>(Sec, Rel);
Fn({cast<InputSectionBase>(D->Section)->Repl, Offset});		Fn({cast<InputSectionBase>(D->Section), Offset});
} else if (auto *U = dyn_cast<Undefined>(&B)) {		} else if (auto *U = dyn_cast<Undefined>(&B)) {
for (InputSectionBase *Sec : CNamedSections.lookup(U->getName()))		for (InputSectionBase *Sec : CNamedSections.lookup(U->getName()))
Fn({Sec, 0});		Fn({Sec, 0});
}		}
}		}

// Calls Fn for each section that Sec refers to via relocations.		// Calls Fn for each section that Sec refers to via relocations.
template <class ELFT>		template <class ELFT>
▲ Show 20 Lines • Show All 179 Lines • Show Last 20 Lines