This is an archive of the discontinued LLVM Phabricator instance.

Differential D34435

Use -NOT prefix instead of adding `not` to FileCheck.
ClosedPublic

Authored by ruiu on Jun 20 2017, 6:15 PM.

Details

Reviewers
yamaguchi
Commits
rG0f8a345fb4b1: Use -NOT prefix instead of adding `not` to FileCheck.
rC305930: Use -NOT prefix instead of adding `not` to FileCheck.
rL305930: Use -NOT prefix instead of adding `not` to FileCheck.
Summary

If we want to make sure that a particular string is not in an output,
the regular way of doing it is to add -NOT prefix instead of checking
if FileCheck resulted in an error.

Diff Detail

Repository
rL LLVM

Event Timeline

ruiu created this revision.Jun 20 2017, 6:15 PM
Harbormaster completed remote builds in B7435: Diff 103313.Jun 20 2017, 6:15 PM
yamaguchi accepted this revision.Jun 20 2017, 8:34 PM

LGTM! Thanks for the fix.

This revision is now accepted and ready to land.Jun 20 2017, 8:34 PM
Closed by commit rL305930: Use -NOT prefix instead of adding `not` to FileCheck. (authored by ruiu). · Explain WhyJun 21 2017, 9:51 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
cfe/
trunk/
test/
Driver/
4 lines

Diff 103414

cfe/trunk/test/Driver/autocomplete.c

// RUN: %clang --autocomplete=-fsyn | FileCheck %s -check-prefix=FSYN // RUN: %clang --autocomplete=-fsyn | FileCheck %s -check-prefix=FSYN
// FSYN: -fsyntax-only // FSYN: -fsyntax-only
// RUN: %clang --autocomplete=-s | FileCheck %s -check-prefix=STD // RUN: %clang --autocomplete=-s | FileCheck %s -check-prefix=STD
// STD: -std={{.*}}-stdlib= // STD: -std={{.*}}-stdlib=
// RUN: %clang --autocomplete=foo | not FileCheck %s -check-prefix=NONE // RUN: %clang --autocomplete=foo | FileCheck %s -check-prefix=FOO
// NONE: foo // FOO-NOT: foo
// RUN: %clang --autocomplete=-stdlib=,l | FileCheck %s -check-prefix=STDLIB // RUN: %clang --autocomplete=-stdlib=,l | FileCheck %s -check-prefix=STDLIB
// STDLIB: libc++ libstdc++ // STDLIB: libc++ libstdc++
// RUN: %clang --autocomplete=-stdlib=, | FileCheck %s -check-prefix=STDLIBALL // RUN: %clang --autocomplete=-stdlib=, | FileCheck %s -check-prefix=STDLIBALL
// STDLIBALL: libc++ libstdc++ platform // STDLIBALL: libc++ libstdc++ platform
// RUN: %clang --autocomplete=-meabi,d | FileCheck %s -check-prefix=MEABI // RUN: %clang --autocomplete=-meabi,d | FileCheck %s -check-prefix=MEABI
// MEABI: default // MEABI: default
// RUN: %clang --autocomplete=-meabi, | FileCheck %s -check-prefix=MEABIALL // RUN: %clang --autocomplete=-meabi, | FileCheck %s -check-prefix=MEABIALL
// MEABIALL: default 4 5 gnu // MEABIALL: default 4 5 gnu
Show All 22 Lines