This is an archive of the discontinued LLVM Phabricator instance.

[Dominators] Move helper functions into SemiNCAInfo
ClosedPublic

Authored by kuhar on Jun 20 2017, 4:12 PM.

Details

Summary

Helper functions (DFSPass, ReverseDFSPass, Eval) need SemiNCAInfo anyway, so it's simpler to have them there as member functions. This also makes them simpler by removing template boilerplate.

Diff Detail

Event Timeline

kuhar created this revision.Jun 20 2017, 4:12 PM
kuhar updated this revision to Diff 103309.Jun 20 2017, 6:06 PM

Calculate doesn't have to be DominatorTreeBase's friend anymore.

dberlin accepted this revision.Jun 21 2017, 7:12 PM

The formatting looks a little odd.
I'm not sure we would name the namespace detail (i'll comment in the patch that adds it)
Otherwise, looks fine.

This revision is now accepted and ready to land.Jun 21 2017, 7:12 PM
kuhar updated this revision to Diff 104068.Jun 26 2017, 6:46 PM

Update the diff.

kuhar updated this revision to Diff 104475.Jun 28 2017, 11:12 AM

Update the diff to apply cleanly.

This revision was automatically updated to reflect the committed changes.