Fix typo in MCObjectDisassembler::getBBAt()

[dblaikie]

Please include llvm-commits in review and, if possible, include a test case.

[dexonsmith]

Hi Maks,

This change is obviously correct, but it should still be possible
to create a failing testcase: it looks to me like no basic blocks
will have successor/predecessor edges without your fix.

(I.e., please write a testcase!)

maksqwe added you to the CC list for the revision "Fix typo in MCObjectDisassembler::getBBAt()".

Hi dblaikie,

http://reviews.llvm.org/D3436

Files:
lib/MC/MCObjectDisassembler.cpp

Index: lib/MC/MCObjectDisassembler.cpp

• lib/MC/MCObjectDisassembler.cpp

+++ lib/MC/MCObjectDisassembler.cpp
@@ -448,7 +448,7 @@

RemoveDupsFromAddressVector(BBI->SuccAddrs);
for (AddressSetTy::const_iterator SI = BBI->SuccAddrs.begin(),
     SE = BBI->SuccAddrs.end();

• SE != SE; ++SI) {

+ SI != SE; ++SI) {

MCBasicBlock *Succ = BBInfos[*SI].BB;
BB->addSuccessor(Succ);
Succ->addPredecessor(BB);

<D3436.1.patch>_______________________________________________
llvm-commits mailing list
[e-mail]
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

lib/MC/MCObjectDisassembler.cpp

     RemoveDupsFromAddressVector(BBI->SuccAddrs);
     for (AddressSetTy::const_iterator SI = BBI->SuccAddrs.begin(),
          SE = BBI->SuccAddrs.end();
-         SE != SE; ++SI) {
+         SI != SE; ++SI) {
       MCBasicBlock *Succ = BBInfos[*SI].BB;
       BB->addSuccessor(Succ);
       Succ->addPredecessor(BB);