This is an archive of the discontinued LLVM Phabricator instance.

[clang-format] Simplify TT_SelectorName assignment logic
AbandonedPublic

Authored by krasimir on Jun 19 2017, 8:03 AM.

Details

Reviewers
djasper
Summary

While trying to understand TT_SelectorName, I found 2 redundant checks.
Removing them doesn't cause any tests to fail.

Event Timeline

krasimir created this revision.Jun 19 2017, 8:03 AM
krasimir retitled this revision from Simplify TT_SelectorName assignment logic to [clang-format] Simplify TT_SelectorName assignment logic.Jun 19 2017, 8:03 AM
djasper edited edge metadata.Jun 19 2017, 8:27 AM

For the test introduced in https://reviews.llvm.org/rL262291, either of the changes causes a TT_SelectorName to become a TT_Unknown. So lets figure out how to make this a difference in observable formatting behavior instead of removing these checks.

krasimir abandoned this revision.Jul 4 2017, 5:33 AM