Allow external projects to run tests via llvm-lit

[garious]

Summary

With this patch, the user can set CMAKE_PREFIX_PATH=<llvm_install_dir>. CMake's find_program() will find llvm-lit.

[garious]

Ping

[garious]

This version uses the lit.py in the llvm source directory unless it is unavailable.

[garious]

Ping. Nothing controversial here. Can I get a +1?

[garious]

Ping

[garious]

This file "cmake/modules/AddLLVM.cmake" ends up in the LLVM install directory. But from that location, the user cannot use the lit macros unless they set LLVM_MAIN_SRC_DIR. Reaching into the source directory is not necessary because the freshly built 'llvm-lit' is also in the LLVM install directory. This patch allows the build to find llvm-lit.

[garious]

Ping. This patch is blocking http://reviews.llvm.org/D3216.

[garious]

I asked some questions about this change in my previous mail.

Sorry, my last reply intended to answer your question, but I see how it wasn't too clear. Take 2:

Is the idea here to support lit testing of an external project or to enable some unusual build configuration of the standard LLVM modules?

The idea here is to support lit testing of both standard LLVM projects as well as external ones. llvm-lit is in the install directory but it is currently inaccessible via the CMake files in the install directory.

[garious]

test if variable is set instead of testing if directory exists

[garious]

Fixed in r209308

cmake/modules/AddLLVM.cmake

   if (NOT CMAKE_CFG_INTDIR STREQUAL ".")
     list(APPEND LIT_ARGS --param build_mode=${CMAKE_CFG_INTDIR})
   endif ()
-  set(LIT_COMMAND
-    ${PYTHON_EXECUTABLE}
-    ${LLVM_MAIN_SRC_DIR}/utils/lit/lit.py
-    ${LIT_ARGS}
-    )
+  if (EXISTS ${LLVM_MAIN_SRC_DIR})
+    set (LIT_COMMAND ${PYTHON_EXECUTABLE} ${LLVM_MAIN_SRC_DIR}/utils/lit/lit.py)
+  else()
+    find_program(LIT_COMMAND llvm-lit)
+  endif ()
+  list(APPEND LIT_COMMAND ${LIT_ARGS})
   foreach(param ${ARG_PARAMS})
     list(APPEND LIT_COMMAND --param ${param})
   endforeach()