This is an archive of the discontinued LLVM Phabricator instance.

[COFF] Drop unused comdat sections when GC is turned off
ClosedPublic

Authored by rnk on Jun 16 2017, 11:20 AM.

Details

Summary

Adds a "Discarded" bool to SectionChunk to indicate if the section was
discarded by COMDAT deduplication. The Writer still just checks
isLive().

Fixes PR33446

Event Timeline

rnk created this revision.Jun 16 2017, 11:20 AM
ruiu accepted this revision.Jun 16 2017, 12:55 PM

LGTM

lld/COFF/Chunks.cpp
236–239

Nice improvement!

This revision is now accepted and ready to land.Jun 16 2017, 12:55 PM
This revision was automatically updated to reflect the committed changes.