This is an archive of the discontinued LLVM Phabricator instance.

Differential D34217

Fixing section name for Darwin platforms for sanitizer coverage
ClosedPublic

Authored by george.karpenkov on Jun 14 2017, 11:54 AM.

Details

Reviewers
kcc
Summary

On Darwin, section names have a 16char length limit

Diff Detail

Event Timeline

george.karpenkov created this revision.Jun 14 2017, 11:54 AM
Herald added subscribers: eraman, mgorny. · View Herald TranscriptJun 14 2017, 11:54 AM
kcc accepted this revision.Jun 14 2017, 4:19 PM

LGTM
(Still: OUCH!)

This revision is now accepted and ready to land.Jun 14 2017, 4:19 PM
george.karpenkov closed this revision.Jun 29 2017, 12:54 PM

Revision Contents

PathSize
lib/
Fuzzer/
test/
2 lines
Transforms/
Instrumentation/
2 lines
test/
Instrumentation/
SanitizerCoverage/
2 lines

Diff 102588

lib/Fuzzer/test/CMakeLists.txt

Show First 20 Lines • Show All 200 Lines • ▼ Show 20 Lines
############################################################################### ###############################################################################
include_directories(..) include_directories(..)
# add_subdirectory(uninstrumented) # add_subdirectory(uninstrumented)
add_subdirectory(no-coverage) add_subdirectory(no-coverage)
add_subdirectory(trace-pc) add_subdirectory(trace-pc)
add_subdirectory(ubsan) add_subdirectory(ubsan)
if (NOT APPLE AND NOT MSVC) if (NOT MSVC)
add_subdirectory(inline-8bit-counters) add_subdirectory(inline-8bit-counters)
endif() endif()
add_library(LLVMFuzzer-DSO1 SHARED DSO1.cpp) add_library(LLVMFuzzer-DSO1 SHARED DSO1.cpp)
add_library(LLVMFuzzer-DSO2 SHARED DSO2.cpp) add_library(LLVMFuzzer-DSO2 SHARED DSO2.cpp)
add_executable(LLVMFuzzer-DSOTest add_executable(LLVMFuzzer-DSOTest
DSOTestMain.cpp DSOTestMain.cpp
▲ Show 20 Lines • Show All 58 Lines • Show Last 20 Lines

lib/Transforms/Instrumentation/SanitizerCoverage.cpp

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines
static const char *const SanCovTracePCGuardName = static const char *const SanCovTracePCGuardName =
"__sanitizer_cov_trace_pc_guard"; "__sanitizer_cov_trace_pc_guard";
static const char *const SanCovTracePCGuardInitName = static const char *const SanCovTracePCGuardInitName =
"__sanitizer_cov_trace_pc_guard_init"; "__sanitizer_cov_trace_pc_guard_init";
static const char *const SanCov8bitCountersInitName = static const char *const SanCov8bitCountersInitName =
"__sanitizer_cov_8bit_counters_init"; "__sanitizer_cov_8bit_counters_init";
static const char *const SanCovGuardsSectionName = "sancov_guards"; static const char *const SanCovGuardsSectionName = "sancov_guards";
static const char *const SanCovCountersSectionName = "sancov_counters"; static const char *const SanCovCountersSectionName = "sancov_cntrs";
static cl::opt<int> ClCoverageLevel( static cl::opt<int> ClCoverageLevel(
"sanitizer-coverage-level", "sanitizer-coverage-level",
cl::desc("Sanitizer Coverage. 0: none, 1: entry block, 2: all blocks, " cl::desc("Sanitizer Coverage. 0: none, 1: entry block, 2: all blocks, "
"3: all blocks and critical edges"), "3: all blocks and critical edges"),
cl::Hidden, cl::init(0)); cl::Hidden, cl::init(0));
static cl::opt<bool> ClTracePC("sanitizer-coverage-trace-pc", static cl::opt<bool> ClTracePC("sanitizer-coverage-trace-pc",
▲ Show 20 Lines • Show All 594 Lines • Show Last 20 Lines

test/Instrumentation/SanitizerCoverage/inline-8bit-counters.ll

; Test -sanitizer-coverage-inline-8bit-counters=1 ; Test -sanitizer-coverage-inline-8bit-counters=1
; RUN: opt < %s -sancov -sanitizer-coverage-level=1 -sanitizer-coverage-inline-8bit-counters=1 -S | FileCheck %s ; RUN: opt < %s -sancov -sanitizer-coverage-level=1 -sanitizer-coverage-inline-8bit-counters=1 -S | FileCheck %s
target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64" target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64"
target triple = "x86_64-unknown-linux-gnu" target triple = "x86_64-unknown-linux-gnu"
define void @foo() { define void @foo() {
entry: entry:
; CHECK: %0 = load i8, i8* getelementptr inbounds ([1 x i8], [1 x i8]* @__sancov_gen_, i64 0, i64 0), !nosanitize ; CHECK: %0 = load i8, i8* getelementptr inbounds ([1 x i8], [1 x i8]* @__sancov_gen_, i64 0, i64 0), !nosanitize
; CHECK: %1 = add i8 %0, 1 ; CHECK: %1 = add i8 %0, 1
; CHECK: store i8 %1, i8* getelementptr inbounds ([1 x i8], [1 x i8]* @__sancov_gen_, i64 0, i64 0), !nosanitize ; CHECK: store i8 %1, i8* getelementptr inbounds ([1 x i8], [1 x i8]* @__sancov_gen_, i64 0, i64 0), !nosanitize
ret void ret void
} }
; CHECK: call void @__sanitizer_cov_8bit_counters_init(i8* bitcast (i8** @__start___sancov_counters to i8*), i8* bitcast (i8** @__stop___sancov_counters to i8*)) ; CHECK: call void @__sanitizer_cov_8bit_counters_init(i8* bitcast (i8** @__start___sancov_cntrs to i8*), i8* bitcast (i8** @__stop___sancov_cntrs to i8*))