This is an archive of the discontinued LLVM Phabricator instance.

Add llvm-pdbutil tool_patterns in lit.cfg
ClosedPublic

Authored by sbc100 on Jun 12 2017, 6:08 PM.

Details

Summary

This means that 'llvm-pdbutil' in test commands will resolve
to the absolute path to the tool, in line with what happens
already for other tools.

This works either way because the bin directory is also
prepended to the PATH. I'm not sure why both methods are
used.

Diff Detail

Repository
rL LLVM

Event Timeline

sbc100 created this revision.Jun 12 2017, 6:08 PM

I noticed this when debugging the recent pdb-none.test test failures.

zturner accepted this revision.Jun 12 2017, 7:22 PM

Oh wait, I get it. This is for lld, not for llvm. Yea I made the same fix for llvm. lgtm

This revision is now accepted and ready to land.Jun 12 2017, 7:22 PM
This revision was automatically updated to reflect the committed changes.