This is an archive of the discontinued LLVM Phabricator instance.

Differential D34081

[opt-viewer] Include default values in help output
ClosedPublic

Authored by modocache on Jun 10 2017, 8:06 AM.

Details

Reviewers
anemet
Commits
rG701386d5316d: [opt-viewer] Include default values in help output
rL305155: [opt-viewer] Include default values in help output
Summary

Python's argparse module includes a %(default)s format specifier that
can be used to print the default value of an option in its help text.
Use this for opt-viewer utilities' --jobs arguments.

Diff Detail

Event Timeline

modocache created this revision.Jun 10 2017, 8:06 AM
Herald added a subscriber: fhahn. · View Herald TranscriptJun 10 2017, 8:06 AM
anemet accepted this revision.Jun 10 2017, 10:38 AM

LGTM, thanks!

This revision is now accepted and ready to land.Jun 10 2017, 10:38 AM
modocache closed this revision.Jun 10 2017, 2:33 PM
modocache added a comment.Jun 10 2017, 2:41 PM

Thanks, @anemet!

Revision Contents

PathSize
utils/
opt-viewer/
2 lines
2 lines
2 lines

Diff 102116

utils/opt-viewer/opt-diff.py

Show All 37 Linesif __name__ == '__main__':
parser = argparse.ArgumentParser(description=desc) parser = argparse.ArgumentParser(description=desc)
parser.add_argument('yaml_dir_or_file_1') parser.add_argument('yaml_dir_or_file_1')
parser.add_argument('yaml_dir_or_file_2') parser.add_argument('yaml_dir_or_file_2')
parser.add_argument( parser.add_argument(
'--jobs', '--jobs',
'-j', '-j',
default=cpu_count(), default=cpu_count(),
type=int, type=int,
help='Max job count (defaults to current CPU count)') help='Max job count (defaults to %(default)s, the current CPU count)')
parser.add_argument('--output', '-o', default='diff.opt.yaml') parser.add_argument('--output', '-o', default='diff.opt.yaml')
args = parser.parse_args() args = parser.parse_args()
if args.jobs == 1: if args.jobs == 1:
pmap = map pmap = map
else: else:
pool = Pool(processes=args.jobs) pool = Pool(processes=args.jobs)
pmap = pool.map pmap = pool.map
Show All 16 Lines

utils/opt-viewer/opt-stats.py

Show All 15 Lines
if __name__ == '__main__': if __name__ == '__main__':
parser = argparse.ArgumentParser(description=desc) parser = argparse.ArgumentParser(description=desc)
parser.add_argument('yaml_files', nargs='+') parser.add_argument('yaml_files', nargs='+')
parser.add_argument( parser.add_argument(
'--jobs', '--jobs',
'-j', '-j',
default=cpu_count(), default=cpu_count(),
type=int, type=int,
help='Max job count (defaults to current CPU count)') help='Max job count (defaults to %(default)s, the current CPU count)')
args = parser.parse_args() args = parser.parse_args()
if len(args.yaml_files) == 0: if len(args.yaml_files) == 0:
parser.print_help() parser.print_help()
sys.exit(1) sys.exit(1)
if args.jobs == 1: if args.jobs == 1:
pmap = map pmap = map
Show All 24 Lines

utils/opt-viewer/opt-viewer.py

Show First 20 Lines • Show All 202 Lines • ▼ Show 20 Linesif __name__ == '__main__':
parser = argparse.ArgumentParser(description=desc) parser = argparse.ArgumentParser(description=desc)
parser.add_argument('yaml_files', nargs='+') parser.add_argument('yaml_files', nargs='+')
parser.add_argument('output_dir') parser.add_argument('output_dir')
parser.add_argument( parser.add_argument(
'--jobs', '--jobs',
'-j', '-j',
default=cpu_count(), default=cpu_count(),
type=int, type=int,
help='Max job count (defaults to current CPU count)') help='Max job count (defaults to %(default)s, the current CPU count)')
parser.add_argument( parser.add_argument(
'-source-dir', '-source-dir',
'-s', '-s',
default='', default='',
help='set source directory') help='set source directory')
args = parser.parse_args() args = parser.parse_args()
if len(args.yaml_files) == 0: if len(args.yaml_files) == 0:
Show All 14 Lines