This is an archive of the discontinued LLVM Phabricator instance.

Only generate addcarry node when it is legal.
ClosedPublic

Authored by deadalnix on Jun 1 2017, 4:49 AM.

Event Timeline

deadalnix created this revision.Jun 1 2017, 4:49 AM
chandlerc accepted this revision.Jun 1 2017, 4:59 AM
chandlerc added a subscriber: chandlerc.

Ok, this seems like a trivial fix to a breakage, but please spell out in the patch description when you commit it what we discussed on IRC:

  • This was uncovered during stage2 of a bootstrap by build bots
  • The patch that introduced it has already had other patches land on top and so trying to avoid lots of revert churn
  • Working on adding a reduced test case that covers this, but wanted to get the build bots back to green ASAP, will land a test case as soon as one is available.
This revision is now accepted and ready to land.Jun 1 2017, 4:59 AM
This revision was automatically updated to reflect the committed changes.