This is an archive of the discontinued LLVM Phabricator instance.

Partial revert of 183015
ClosedPublic

Authored by eugenis on Apr 14 2014, 2:46 AM.

Details

Reviewers
rsmith
Summary

Re-enable several builtins in non-gnu modes.
Fixes PR16138.

Diff Detail

Event Timeline

Looks OK as a short-term fix for the ones with the "j" flag. Do we really need to do this for the "fn" ones?

You mean "fr". Not necessary, I guess. Missing (noreturn) attribute can not do much harm.

eugenis updated this revision to Unknown Object (????).Apr 15 2014, 1:11 AM

Reverted changes for "pr" builtins.
The only ones that are re-enabled now are "j" - i.e., returns_twice.
PTAL

rsmith accepted this revision.Apr 15 2014, 1:31 PM

LGTM

rsmith added inline comments.Apr 15 2014, 1:33 PM
include/clang/Basic/Builtins.def
740–743

Please update this comment to explain why we don't have ALL_GNU_LANGUAGES for those builtins with the 'j' flag.

eugenis updated this revision to Unknown Object (????).Apr 16 2014, 1:03 AM
eugenis added inline comments.
include/clang/Basic/Builtins.def
740–743

done

eugenis closed this revision.Apr 16 2014, 1:13 AM

Committed in r206362.