This is an archive of the discontinued LLVM Phabricator instance.

Differential D33659

Extend DynamicLibrary class to be usable without loading permanently.
Needs ReviewPublic

Authored by marsupial on May 29 2017, 2:07 PM.

Details

Reviewers
krememek
akyrtzi

Diff Detail

Revision Contents

Diff 105466

lib/StaticAnalyzer/Frontend/CheckerRegistration.cpp

Show First 20 Lines • Show All 47 Lines • ▼ Show 20 Lines
ClangCheckerRegistry::ClangCheckerRegistry(ArrayRef<std::string> plugins, ClangCheckerRegistry::ClangCheckerRegistry(ArrayRef<std::string> plugins,
DiagnosticsEngine *diags) { DiagnosticsEngine *diags) {
registerBuiltinCheckers(*this); registerBuiltinCheckers(*this);
for (ArrayRef<std::string>::iterator i = plugins.begin(), e = plugins.end(); for (ArrayRef<std::string>::iterator i = plugins.begin(), e = plugins.end();
i != e; ++i) { i != e; ++i) {
// Get access to the plugin. // Get access to the plugin.
std::string err; std::string err;
DynamicLibrary lib = DynamicLibrary::getPermanentLibrary(i->c_str(), &err); DynamicLibrary *lib = DynamicLibrary::getPermanentLibrary(i->c_str(), &err);
if (!lib.isValid()) { if (!lib) {
diags->Report(diag::err_fe_unable_to_load_plugin) << *i << err; diags->Report(diag::err_fe_unable_to_load_plugin) << *i << err;
continue; continue;
} }
// See if it's compatible with this build of clang. // See if it's compatible with this build of clang.
const char *pluginAPIVersion = const char *pluginAPIVersion =
(const char *) lib.getAddressOfSymbol("clang_analyzerAPIVersionString"); (const char *) lib->getAddressOfSymbol("clang_analyzerAPIVersionString");
if (!isCompatibleAPIVersion(pluginAPIVersion)) { if (!isCompatibleAPIVersion(pluginAPIVersion)) {
warnIncompatible(diags, *i, pluginAPIVersion); warnIncompatible(diags, *i, pluginAPIVersion);
continue; continue;
} }
// Register its checkers. // Register its checkers.
RegisterCheckersFn registerPluginCheckers = RegisterCheckersFn registerPluginCheckers =
(RegisterCheckersFn) (intptr_t) lib.getAddressOfSymbol( (RegisterCheckersFn) (intptr_t) lib->getAddressOfSymbol(
"clang_registerCheckers"); "clang_registerCheckers");
if (registerPluginCheckers) if (registerPluginCheckers)
registerPluginCheckers(*this); registerPluginCheckers(*this);
} }
} }
bool ClangCheckerRegistry::isCompatibleAPIVersion(const char *versionString) { bool ClangCheckerRegistry::isCompatibleAPIVersion(const char *versionString) {
// If the version string is null, it's not an analyzer plugin. // If the version string is null, it's not an analyzer plugin.
▲ Show 20 Lines • Show All 74 Lines • Show Last 20 Lines