Details
- Reviewers
chandlerc aaron.ballman
Diff Detail
Event Timeline
Can you add some unit tests?
include/llvm/ADT/iterator_range.h | ||
---|---|---|
67 | function -> functions |
include/llvm/ADT/iterator_range.h | ||
---|---|---|
75–87 | Doesn't reverse_range duplicate the reverse we already have in STLExtras.h? |
include/llvm/ADT/iterator_range.h | ||
---|---|---|
75–87 | Thats all I really wanted...Should I add a comment it's there? |
include/llvm/ADT/iterator_range.h | ||
---|---|---|
75–87 | Personally, I think we should move the range-based utilities out of STLExtras.h and into a header that is more likely to be found. Either this one or something quite clearly providing range-based algos and adapters. |
include/llvm/ADT/iterator_range.h | ||
---|---|---|
75–87 | Doing that right and making sure includes are updated properly seems like a lengthy process (which I personally don't have time for right now). The hint seems adequate to those trying to glean where these may be located, but if it's not wanted I can close this out all together. |
function -> functions
stl-like containers -> containers