This is an archive of the discontinued LLVM Phabricator instance.

Add note for location of other convenience functions.
Needs ReviewPublic

Authored by marsupial on May 29 2017, 10:57 AM.

Details

Diff Detail

Event Timeline

marsupial created this revision.May 29 2017, 10:57 AM
aaron.ballman edited edge metadata.May 30 2017, 6:23 AM

Can you add some unit tests?

include/llvm/ADT/iterator_range.h
67

function -> functions
stl-like containers -> containers

majnemer added inline comments.
include/llvm/ADT/iterator_range.h
75–87

Doesn't reverse_range duplicate the reverse we already have in STLExtras.h?

marsupial added inline comments.May 30 2017, 8:53 AM
include/llvm/ADT/iterator_range.h
75–87

Thats all I really wanted...Should I add a comment it's there?

marsupial retitled this revision from [ADT] Add convenience functions for making forward and reverse ranges with an STL container. to Add note for location of other convenience functions..
chandlerc added inline comments.May 30 2017, 1:40 PM
include/llvm/ADT/iterator_range.h
75–87

Personally, I think we should move the range-based utilities out of STLExtras.h and into a header that is more likely to be found. Either this one or something quite clearly providing range-based algos and adapters.

marsupial added inline comments.May 30 2017, 3:04 PM
include/llvm/ADT/iterator_range.h
75–87

Doing that right and making sure includes are updated properly seems like a lengthy process (which I personally don't have time for right now).

The hint seems adequate to those trying to glean where these may be located, but if it's not wanted I can close this out all together.