Fixing broken builds

[ravitheja]

Summary

For the differential D32585, size_t was incorrectly used
where uint64_t should have been used.

[labath]

I had just committed a fix for that. You simply shouldn't have explicitly specified the template arg in the GetValueAsInteger calls. If you still want to make these uint64_t (I don't think it's necessary, as you won't be able to allocate more memory than size_t anyway), then we can do that, but then you should change the numeric_limits type as well.

[ravitheja]

Using uint64_t everywhere.

[ravitheja]

@labath Thanx for fixing the 32 bit builds, I am sorry for the trouble caused.

[labath]

I don't see a reason to change, but I don't mind it either.

source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp

GDBRemoteCommunicationServerLLGS::Handle_jTraceRead(
   else if (packet.ConsumeFront("jTraceMetaRead:"))
     tracetype = MetaData;
   else {
     return SendIllFormedResponse(packet, "jTrace: Ill formed packet ");
   }
 
   lldb::user_id_t uid = LLDB_INVALID_UID;
 
-  size_t byte_count = std::numeric_limits<size_t>::max();
+  uint64_t byte_count = std::numeric_limits<uint64_t>::max();
   lldb::tid_t tid = LLDB_INVALID_THREAD_ID;
-  size_t offset = std::numeric_limits<size_t>::max();
+  uint64_t offset = std::numeric_limits<uint64_t>::max();
 
   auto json_object = StructuredData::ParseJSON(packet.Peek());
 
   if (!json_object ||
       json_object->GetType() != StructuredData::Type::eTypeDictionary)
     return SendIllFormedResponse(packet, "jTrace: Ill formed packet ");
 
   auto json_dict = json_object->GetAsDictionary();
GDBRemoteCommunicationServerLLGS::Handle_jTraceRead(
   if (tracetype == BufferData)
     error = m_debugged_process_sp->GetData(uid, tid, buf, offset);
   else if (tracetype == MetaData)
     error = m_debugged_process_sp->GetMetaData(uid, tid, buf, offset);
 
   if (error.Fail())
     return SendErrorResponse(error.GetError());
 
-  for (size_t i = 0; i < buf.size(); ++i)
+  for (uint64_t i = 0; i < buf.size(); ++i)
     response.PutHex8(buf[i]);
 
   StreamGDBRemote escaped_response;
   escaped_response.PutEscapedBytes(response.GetData(), response.GetSize());
   return SendPacketNoLock(escaped_response.GetString());
 }
 
 GDBRemoteCommunication::PacketResult