This is an archive of the discontinued LLVM Phabricator instance.

[lsan] Report the missing linker only when the linker is actually missing.
ClosedPublic

Authored by alekseyshl on May 15 2017, 3:47 PM.

Reviewers

Commits

Build Status

Buildable 6457
Build 6457: arc lint + arc unit

Nice :)

This revision is now accepted and ready to land.May 15 2017, 4:07 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

lib/

lsan/

6 lines

Show First 20 Lines • Show All 56 Lines • ▼ Show 20 Lines	for (LoadedModule &module : modules) {
} else {		} else {
VReport(1, "LeakSanitizer: Multiple modules match \"%s\". "		VReport(1, "LeakSanitizer: Multiple modules match \"%s\". "
"TLS will not be handled correctly.\n", kLinkerName);		"TLS will not be handled correctly.\n", kLinkerName);
linker->clear();		linker->clear();
linker = nullptr;		linker = nullptr;
return;		return;
}		}
}		}
		if (linker == nullptr) {
VReport(1, "LeakSanitizer: Dynamic linker not found. "		VReport(1, "LeakSanitizer: Dynamic linker not found. "
"TLS will not be handled correctly.\n");		"TLS will not be handled correctly.\n");
}		}
		}

static int ProcessGlobalRegionsCallback(struct dl_phdr_info *info, size_t size,		static int ProcessGlobalRegionsCallback(struct dl_phdr_info *info, size_t size,
void *data) {		void *data) {
Frontier frontier = reinterpret_cast<Frontier >(data);		Frontier frontier = reinterpret_cast<Frontier >(data);
for (uptr j = 0; j < info->dlpi_phnum; j++) {		for (uptr j = 0; j < info->dlpi_phnum; j++) {
const ElfW(Phdr) *phdr = &(info->dlpi_phdr[j]);		const ElfW(Phdr) *phdr = &(info->dlpi_phdr[j]);
// We're looking for .data and .bss sections, which reside in writeable,		// We're looking for .data and .bss sections, which reside in writeable,
// loadable segments.		// loadable segments.
▲ Show 20 Lines • Show All 48 Lines • Show Last 20 Lines