Page MenuHomePhabricator

[analyzer] Avoid allocation in Std C function modelling.
ClosedPublic

Authored by xazax.hun on May 11 2017, 4:23 AM.

Event Timeline

xazax.hun created this revision.May 11 2017, 4:23 AM
NoQ accepted this revision.EditedMay 11 2017, 10:44 PM

Thanks :o

I guess i was planning for C++ support here, but never reached that far.

Is it an actual performance problem? Cause i think i did somehow test the checker for performance regressions and it seemed all good.

This revision is now accepted and ready to land.May 11 2017, 10:44 PM
In D33095#752879, @NoQ wrote:

Is it an actual performance problem? Cause i think i did somehow test the checker for performance regressions and it seemed all good.

I did not measure it. Just spotted by skimming through the code. I think, this is not a performance problem, but since it is easy to avoid the allocation and this codepath might be executed for every call, it might be worth to fix this.

This revision was automatically updated to reflect the committed changes.