This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] libc++ test changes for CWG 2094
ClosedPublic

Authored by BillyONeal on May 9 2017, 4:48 PM.

Details

Summary

Update is_trivially_copyable tests with CWG 2094

Clang 5.0 implements these changes here: https://github.com/llvm-mirror/clang/commit/87cd035326a39523eeb1b295ad36cff337141ef9
MSVC++ will implement these changes in the first toolset update to 2017.

Diff Detail

Repository
rL LLVM

Event Timeline

BillyONeal created this revision.May 9 2017, 4:48 PM
BillyONeal added inline comments.May 9 2017, 4:51 PM
test/std/utilities/meta/meta.unary/meta.unary.prop/is_trivially_copyable.pass.cpp
25 ↗(On Diff #98368)

Whoops, I fat fingered the closing comment. Will change this to just say "compiler version"

BillyONeal updated this revision to Diff 98370.May 9 2017, 4:59 PM
BillyONeal edited the summary of this revision. (Show Details)

Eric asked to just nuke the offending lines.

BillyONeal marked an inline comment as done.May 9 2017, 4:59 PM
BillyONeal updated this revision to Diff 98376.May 9 2017, 5:27 PM

Bill got confused.

BillyONeal edited the summary of this revision. (Show Details)May 9 2017, 5:34 PM
mclow.lists edited edge metadata.May 10 2017, 6:15 AM

In general, I prefer having the space between static_assert( and the condition.

That makes it easy (at least for me) to see if there's a ! there or not.
Other than that, this LGTM.

FWIW, I think this is a language change that core got wrong, and it has already come back to bite us. (https://bugs.llvm.org/show_bug.cgi?id=28527)

FWIW, I think this is a language change that core got wrong, and it has already come back to bite us. (https://bugs.llvm.org/show_bug.cgi?id=28527)

Hmm.... we actually took steps to do the opposite in std::copy -- to use memcpy even in the presence of volatile -- as a result of this change.

It looks like Core wasn't a fan of doing this either, but that the Itanium ABI forced their hand.

Hmm.... we actually took steps to do the opposite in std::copy -- to use memcpy even in the presence of volatile -- as a result of this change.

;) http://imgur.com/a/PMKPS

EricWF accepted this revision.May 10 2017, 12:40 PM

LGTM. The bots are already failing because I upgraded their compilers.

@BillyONeal Can you commit this soon so I can clean up any fallout?

This revision is now accepted and ready to land.May 10 2017, 12:40 PM

Added spaces requested by Marshal.

This revision was automatically updated to reflect the committed changes.