This is an archive of the discontinued LLVM Phabricator instance.

Fix code section prefix for proper layout
ClosedPublic

Authored by tejohnson on May 8 2017, 3:48 PM.

Details

Summary

r284533 added hot and cold section prefixes based on profile
information, to enable grouping of hot/cold functions at link time.
However, it used "cold" as the prefix for cold sections, but gold only
recognizes "unlikely" (which is used by gcc for cold sections).
Therefore, cold sections were not properly being grouped. Switch to
using "unlikely"

Diff Detail

Repository
rL LLVM

Event Timeline

tejohnson created this revision.May 8 2017, 3:48 PM
danielcdh accepted this revision.May 8 2017, 3:53 PM
This revision is now accepted and ready to land.May 8 2017, 3:53 PM
This revision was automatically updated to reflect the committed changes.