This is an archive of the discontinued LLVM Phabricator instance.

Ignore !associated metadata with null argument
ClosedPublic

Authored by eugenis on May 8 2017, 1:50 PM.

Reviewers

pcc

Summary

Fixes PR32577 (comment 10).
Such metadata may legitimately appear in LTO.

LGTM

This revision is now accepted and ready to land.May 8 2017, 4:51 PM

r302485

Path

Size

lib/

CodeGen/

6 lines

test/

CodeGen/

X86/

5 lines

	Show First 20 Lines • Show All 226 Lines • ▼ Show 20 Lines
	}			}

	static const MCSymbolELF getAssociatedSymbol(const GlobalObject GO,			static const MCSymbolELF getAssociatedSymbol(const GlobalObject GO,
	const TargetMachine &TM) {			const TargetMachine &TM) {
	MDNode *MD = GO->getMetadata(LLVMContext::MD_associated);			MDNode *MD = GO->getMetadata(LLVMContext::MD_associated);
	if (!MD)			if (!MD)
	return nullptr;			return nullptr;

	auto *VM = dyn_cast<ValueAsMetadata>(MD->getOperand(0));			const MDOperand &Op = MD->getOperand(0);
				if (!Op.get())
				return nullptr;

				auto *VM = dyn_cast<ValueAsMetadata>(Op);
	if (!VM)			if (!VM)
	report_fatal_error("MD_associated operand is not ValueAsMetadata");			report_fatal_error("MD_associated operand is not ValueAsMetadata");

	GlobalObject *OtherGO = dyn_cast<GlobalObject>(VM->getValue());			GlobalObject *OtherGO = dyn_cast<GlobalObject>(VM->getValue());
	return OtherGO ? dyn_cast<MCSymbolELF>(TM.getSymbol(OtherGO)) : nullptr;			return OtherGO ? dyn_cast<MCSymbolELF>(TM.getSymbol(OtherGO)) : nullptr;
	}			}

	MCSection *TargetLoweringObjectFileELF::getExplicitSectionGlobal(			MCSection *TargetLoweringObjectFileELF::getExplicitSectionGlobal(
	▲ Show 20 Lines • Show All 1,040 Lines • Show Last 20 Lines

	Show All 31 Lines
	; CHECK-DAG: .section bbb,"awo",@progbits,h,unique,1			; CHECK-DAG: .section bbb,"awo",@progbits,h,unique,1
	; CHECK-DAG: .section bbb,"awo",@progbits,h,unique,2			; CHECK-DAG: .section bbb,"awo",@progbits,h,unique,2
	; CHECK-DAG: .section .data.k,"awo",@progbits,h			; CHECK-DAG: .section .data.k,"awo",@progbits,h

	; Non-GlobalObject metadata.			; Non-GlobalObject metadata.
	@l = global i32 1, section "ccc", !associated !5			@l = global i32 1, section "ccc", !associated !5
	!5 = !{i32* null}			!5 = !{i32* null}
	; CHECK-DAG: .section ccc,"aw",@progbits			; CHECK-DAG: .section ccc,"aw",@progbits

				; Null metadata.
				@m = global i32 1, section "ddd", !associated !6
				!6 = distinct !{null}
				; CHECK-DAG: .section ddd,"aw",@progbits