Page MenuHomePhabricator

[index] Index simple dependent declaration references
ClosedPublic

Authored by arphaman on May 8 2017, 10:20 AM.

Details

Summary

This patch implements basic support for indexing of dependent declaration references. Now the indexer tries to find a suitable match in the base template for a dependent member ref/decl ref/dependent type.

This will be used to improve the "go-to-definition" / "find usages" features in Xcode.

Diff Detail

Repository
rL LLVM

Event Timeline

arphaman created this revision.May 8 2017, 10:20 AM
benlangmuir accepted this revision.May 9 2017, 9:29 AM

A couple of minor comments, but otherwise LGTM.

include/clang/AST/DeclCXX.h
1569 ↗(On Diff #98184)

Since the other params are documented above, this should be too.

lib/AST/CXXInheritance.cpp
281 ↗(On Diff #98184)

Please put {} around this else. The first two times I read this I thought the following if was nested inside this else.

This revision is now accepted and ready to land.May 9 2017, 9:29 AM
This revision was automatically updated to reflect the committed changes.
arphaman marked 2 inline comments as done.