This is an archive of the discontinued LLVM Phabricator instance.

Differential D32939

Kaleidoscope - toy.cpp use after move fix
ClosedPublic

Authored by szepet on May 6 2017, 7:08 AM.

Details

Reviewers
lhames
chapuni
Commits
rG5305d3933a55: [Kaleidoscope] toy.cpp use after move fix
rL302369: [Kaleidoscope] toy.cpp use after move fix
Summary

The variable Proto is moved at the beginning of the codegen() function.
According to the comment above, the pointed object should be used due the reference P.

Note: This bug was found by the MisusedMovedObject checker, part of the Clang Static Analyzer.

Diff Detail

Repository
rL LLVM

Event Timeline

szepet created this revision.May 6 2017, 7:08 AM
lhames accepted this revision.May 6 2017, 10:08 AM

Thanks for the fix! Do you have commit access? If so, commit away. If not: let me know and I'll commit it on your behalf.

This revision is now accepted and ready to land.May 6 2017, 10:08 AM
Closed by commit rL302369: [Kaleidoscope] toy.cpp use after move fix (authored by szepet). · Explain WhyMay 7 2017, 4:14 AM
This revision was automatically updated to reflect the committed changes.
szepet added a comment.May 7 2017, 4:22 AM

Thanks for the fast review!

szepet mentioned this in D38675: [analyzer] MoveChecker Pt.10: Move the checker out of alpha state..Oct 8 2017, 10:01 AM

Revision Contents

PathSize
llvm/
trunk/
examples/
Kaleidoscope/
BuildingAJIT/
Chapter1/
2 lines
Chapter2/
2 lines
Chapter3/
2 lines
Chapter6/
2 lines
Chapter7/
2 lines
Chapter8/
2 lines

Diff 98099

llvm/trunk/examples/Kaleidoscope/BuildingAJIT/Chapter1/toy.cpp

Show First 20 Lines • Show All 1,086 Lines • ▼ Show 20 Lines if (Value *RetVal = Body->codegen()) {
return TheFunction; return TheFunction;
} }
// Error reading body, remove function. // Error reading body, remove function.
TheFunction->eraseFromParent(); TheFunction->eraseFromParent();
if (P.isBinaryOp()) if (P.isBinaryOp())
BinopPrecedence.erase(Proto->getOperatorName()); BinopPrecedence.erase(P.getOperatorName());
return nullptr; return nullptr;
} }
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// Top-Level parsing and JIT Driver // Top-Level parsing and JIT Driver
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
static void InitializeModule() { static void InitializeModule() {
▲ Show 20 Lines • Show All 130 Lines • Show Last 20 Lines

llvm/trunk/examples/Kaleidoscope/BuildingAJIT/Chapter2/toy.cpp

Show First 20 Lines • Show All 1,086 Lines • ▼ Show 20 Lines if (Value *RetVal = Body->codegen()) {
return TheFunction; return TheFunction;
} }
// Error reading body, remove function. // Error reading body, remove function.
TheFunction->eraseFromParent(); TheFunction->eraseFromParent();
if (P.isBinaryOp()) if (P.isBinaryOp())
BinopPrecedence.erase(Proto->getOperatorName()); BinopPrecedence.erase(P.getOperatorName());
return nullptr; return nullptr;
} }
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// Top-Level parsing and JIT Driver // Top-Level parsing and JIT Driver
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
static void InitializeModule() { static void InitializeModule() {
▲ Show 20 Lines • Show All 130 Lines • Show Last 20 Lines

llvm/trunk/examples/Kaleidoscope/BuildingAJIT/Chapter3/toy.cpp

Show First 20 Lines • Show All 1,086 Lines • ▼ Show 20 Lines if (Value *RetVal = Body->codegen()) {
return TheFunction; return TheFunction;
} }
// Error reading body, remove function. // Error reading body, remove function.
TheFunction->eraseFromParent(); TheFunction->eraseFromParent();
if (P.isBinaryOp()) if (P.isBinaryOp())
BinopPrecedence.erase(Proto->getOperatorName()); BinopPrecedence.erase(P.getOperatorName());
return nullptr; return nullptr;
} }
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// Top-Level parsing and JIT Driver // Top-Level parsing and JIT Driver
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
static void InitializeModule() { static void InitializeModule() {
▲ Show 20 Lines • Show All 130 Lines • Show Last 20 Lines

llvm/trunk/examples/Kaleidoscope/Chapter6/toy.cpp

Show First 20 Lines • Show All 926 Lines • ▼ Show 20 Lines if (Value *RetVal = Body->codegen()) {
return TheFunction; return TheFunction;
} }
// Error reading body, remove function. // Error reading body, remove function.
TheFunction->eraseFromParent(); TheFunction->eraseFromParent();
if (P.isBinaryOp()) if (P.isBinaryOp())
BinopPrecedence.erase(Proto->getOperatorName()); BinopPrecedence.erase(P.getOperatorName());
return nullptr; return nullptr;
} }
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// Top-Level parsing and JIT Driver // Top-Level parsing and JIT Driver
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
static void InitializeModuleAndPassManager() { static void InitializeModuleAndPassManager() {
▲ Show 20 Lines • Show All 149 Lines • Show Last 20 Lines

llvm/trunk/examples/Kaleidoscope/Chapter7/toy.cpp

Show First 20 Lines • Show All 1,093 Lines • ▼ Show 20 Lines if (Value *RetVal = Body->codegen()) {
return TheFunction; return TheFunction;
} }
// Error reading body, remove function. // Error reading body, remove function.
TheFunction->eraseFromParent(); TheFunction->eraseFromParent();
if (P.isBinaryOp()) if (P.isBinaryOp())
BinopPrecedence.erase(Proto->getOperatorName()); BinopPrecedence.erase(P.getOperatorName());
return nullptr; return nullptr;
} }
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// Top-Level parsing and JIT Driver // Top-Level parsing and JIT Driver
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
static void InitializeModuleAndPassManager() { static void InitializeModuleAndPassManager() {
▲ Show 20 Lines • Show All 152 Lines • Show Last 20 Lines

llvm/trunk/examples/Kaleidoscope/Chapter8/toy.cpp

Show First 20 Lines • Show All 1,091 Lines • ▼ Show 20 Lines if (Value *RetVal = Body->codegen()) {
return TheFunction; return TheFunction;
} }
// Error reading body, remove function. // Error reading body, remove function.
TheFunction->eraseFromParent(); TheFunction->eraseFromParent();
if (P.isBinaryOp()) if (P.isBinaryOp())
BinopPrecedence.erase(Proto->getOperatorName()); BinopPrecedence.erase(P.getOperatorName());
return nullptr; return nullptr;
} }
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// Top-Level parsing and JIT Driver // Top-Level parsing and JIT Driver
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
static void InitializeModuleAndPassManager() { static void InitializeModuleAndPassManager() {
▲ Show 20 Lines • Show All 161 Lines • Show Last 20 Lines