This is an archive of the discontinued LLVM Phabricator instance.

Paths

[libcxx] [test] Fix MSVC "warning C6326: Potential comparison of a constant with another constant".
ClosedPublic

Authored by STL_MSFT on May 5 2017, 3:03 PM.

Reviewers

EricWF
mclow.lists

Summary

[libcxx] [test] Fix MSVC "warning C6326: Potential comparison of a constant with another constant".

The expressions 1 == 1 and true have the same type, value category, and value.

This revision is now accepted and ready to land.May 5 2017, 4:37 PM

Path

Size

test/

std/

containers/

sequences/

vector.bool/

4 lines

Show First 20 Lines • Show All 42 Lines • ▼ Show 20 Lines	#else
c.emplace_back();		c.emplace_back();
assert(c.size() == 1);		assert(c.size() == 1);
assert(c.front() == false);		assert(c.front() == false);
c.emplace_back(true);		c.emplace_back(true);
assert(c.size() == 2);		assert(c.size() == 2);
assert(c.front() == false);		assert(c.front() == false);
assert(c.back() == true);		assert(c.back() == true);
#endif		#endif
c.emplace_back(1 == 1);		c.emplace_back(true);
assert(c.size() == 3);		assert(c.size() == 3);
assert(c.front() == false);		assert(c.front() == false);
assert(c[1] == true);		assert(c[1] == true);
assert(c.back() == true);		assert(c.back() == true);
}		}
{		{
typedef std::vector<bool, min_allocator<bool>> C;		typedef std::vector<bool, min_allocator<bool>> C;
C c;		C c;
Show All 17 Lines	#else
c.emplace_back();		c.emplace_back();
assert(c.size() == 1);		assert(c.size() == 1);
assert(c.front() == false);		assert(c.front() == false);
c.emplace_back(true);		c.emplace_back(true);
assert(c.size() == 2);		assert(c.size() == 2);
assert(c.front() == false);		assert(c.front() == false);
assert(c.back() == true);		assert(c.back() == true);
#endif		#endif
c.emplace_back(1 == 1);		c.emplace_back(true);
assert(c.size() == 3);		assert(c.size() == 3);
assert(c.front() == false);		assert(c.front() == false);
assert(c[1] == true);		assert(c[1] == true);
assert(c.back() == true);		assert(c.back() == true);
}		}
}		}