This is an archive of the discontinued LLVM Phabricator instance.

[PM] Add ProfileSummaryAnalysis as a required pass in the new pipeline.
ClosedPublic

Authored by eraman on May 2 2017, 4:11 PM.

Diff Detail

Event Timeline

eraman created this revision.May 2 2017, 4:11 PM
davide added a subscriber: davide.May 2 2017, 5:30 PM
davide added inline comments.
lib/Passes/PassBuilder.cpp
505–511

Please add a comment explanining why we require it.

eraman updated this revision to Diff 97699.May 3 2017, 11:46 AM

Address review comments.

eraman marked an inline comment as done.May 3 2017, 11:47 AM

This is reasonable. Did you get failures because the profile info weren't available in the inliner?

eraman updated this revision to Diff 97756.May 3 2017, 5:41 PM

Add a test case.

eraman added a comment.May 3 2017, 5:43 PM

I've added a test case for this which verifies that hot callsite threshold is applied with the default O2 pipeline. I don't see any other similar instances (running with the full O2 pipeline and checking the transformation has happened) but I hope this is fine.

chandlerc accepted this revision.May 3 2017, 6:01 PM

LGTM, excited! (But if you can, maybe wait for davide to confirm this is what he was looking for?)

This revision is now accepted and ready to land.May 3 2017, 6:01 PM
davide accepted this revision.May 3 2017, 8:36 PM

LGTM. very excited too :)

This revision was automatically updated to reflect the committed changes.