In CommandObjectRegisterRead.DoExecute(), set the status to "success" when appropriate.
Thanks for the patch. Could you please also add an appropriate test for it? Doing something similar to what packages/Python/lldbsuite/test/functionalities/frame_var/TestFrameVar.py does should be the easiest way to test this.
that sounds like an excellent idea, as it will check all executed commands, and not the ones we've remembered checking. It should probably be an lldbassert though. (And we'd need to check that the existing tests still pass after that.)
Yes: lldbassert would be fine for that since those get compiled out during release. Patch looks fine. If we already have a test that would trigger the new "lldbassert" you will add, then no need for a special test for this, else we need a test that triggers this.
This is sure to trigger things in the test suite. We will need to ensure a few things:
- test suite runs cleanly in debug mode after the lldbassert is added
- without changes to CommandObjectRegister.cpp that the lldbassert is triggered, and if not, add a test