[Tooling][libclang] Remove unused CompilationDatabase::MappedSources

[krasimir]

Summary

This field is never assigned to and it's only ever read from libclang.
This patch removes it and adapts libclang to return constants.

[bkramer]

lg from my side. It would be good to wait until Manuel is back though, I think he had plans for extending this interface at some point.

[klimek]

Is there a specific reason to take this out? It seems generally useful to allow compilation-db implementors to provide sources.

[krasimir]

@klimek: We don't have any clients of this field inside clang.

[krasimir]

@klimek: ping

[krasimir]

@klimek: ping

[klimek]

LG

cfe/trunk/include/clang/Tooling/CompilationDatabase.h

struct CompileCommand {
   /// The source file associated with the command.
   std::string Filename;
 
   /// \brief The command line that was executed.
   std::vector<std::string> CommandLine;
 
   /// The output file associated with the command.
   std::string Output;
-
-  /// \brief An optional mapping from each file's path to its content for all
-  /// files needed for the compilation that are not available via the file
-  /// system.
-  ///
-  /// Note that a tool implementation is required to fall back to the file
-  /// system if a source file is not provided in the mapped sources, as
-  /// compilation databases will usually not provide all files in mapped sources
-  /// for performance reasons.
-  std::vector<std::pair<std::string, std::string> > MappedSources;
 };
 
 /// \brief Interface for compilation databases.
 ///
 /// A compilation database allows the user to retrieve all compile command lines
 /// that a specified file is compiled with in a project.
 /// The retrieved compile command lines can be used to run clang tools over
 /// a subset of the files in a project.

cfe/trunk/tools/libclang/CXCompilationDatabase.cpp

if (Arg >= Cmd->CommandLine.size())
     return cxstring::createNull();
 
   return cxstring::createRef(Cmd->CommandLine[Arg].c_str());
 }
 
 unsigned
 clang_CompileCommand_getNumMappedSources(CXCompileCommand CCmd)
 {
-  if (!CCmd)
-    return 0;
-
-  return static_cast<CompileCommand *>(CCmd)->MappedSources.size();
+  // Left here for backward compatibility. No mapped sources exists in the C++
+  // backend anymore.
 }
 
 CXString
 clang_CompileCommand_getMappedSourcePath(CXCompileCommand CCmd, unsigned I)
 {
-  if (!CCmd)
-    return cxstring::createNull();
-
-  CompileCommand *Cmd = static_cast<CompileCommand *>(CCmd);
-
-  if (I >= Cmd->MappedSources.size())
-    return cxstring::createNull();
-
-  return cxstring::createRef(Cmd->MappedSources[I].first.c_str());
+  // Left here for backward compatibility. No mapped sources exists in the C++
+  // backend anymore.
 }
 
 CXString
 clang_CompileCommand_getMappedSourceContent(CXCompileCommand CCmd, unsigned I)
 {
-  if (!CCmd)
-    return cxstring::createNull();
-
-  CompileCommand *Cmd = static_cast<CompileCommand *>(CCmd);
-
-  if (I >= Cmd->MappedSources.size())
-    return cxstring::createNull();
-
-  return cxstring::createRef(Cmd->MappedSources[I].second.c_str());
+  // Left here for backward compatibility. No mapped sources exists in the C++
+  // backend anymore.
 }