[OpenMP] libomptarget: Remove obsolete negative device IDs -2/-3

[grokos]

Summary

Early implementations of IBM's internal declare target implementation would call __tgt_target with device IDs -2 and -3 to denote constructors and destructors, respectively. The upcoming declare target patch for clang uses dedicated bits (__tgt_offload_entry::flags) to denote ctors/dtors, so the code handling calls to __tgt_target with devices IDs -2 and -3 is obsolete.

[Hahnfeld]

LGTM, not currently used in Clang.

openmp/trunk/libomptarget/src/omptarget.h

 #define _OMPTARGET_H_
 
 #include <stdint.h>
 
 #define OFFLOAD_SUCCESS (0)
 #define OFFLOAD_FAIL (~0)
 
 #define OFFLOAD_DEVICE_DEFAULT     -1
-#define OFFLOAD_DEVICE_CONSTRUCTOR -2
-#define OFFLOAD_DEVICE_DESTRUCTOR  -3
 #define HOST_DEVICE                -10
 
 /// Data attributes for each data reference used in an OpenMP target region.
 enum tgt_map_type {
   // No flags
   OMP_TGT_MAPTYPE_NONE            = 0x000,
   // copy data from host to device
   OMP_TGT_MAPTYPE_TO              = 0x001,

openmp/trunk/libomptarget/src/omptarget.cpp

if (rt != OFFLOAD_SUCCESS) {
     rc = OFFLOAD_FAIL;
   }
 
   return rc;
 }
 
 EXTERN int __tgt_target(int32_t device_id, void *host_ptr, int32_t arg_num,
     void **args_base, void **args, int64_t *arg_sizes, int32_t *arg_types) {
-  if (device_id == OFFLOAD_DEVICE_CONSTRUCTOR ||
-      device_id == OFFLOAD_DEVICE_DESTRUCTOR) {
-    // Return immediately for the time being, target calls with device_id
-    // -2 or -3 will be removed from the compiler in the future.
-    return OFFLOAD_SUCCESS;
-  }
-
   DP("Entering target region with entry point " DPxMOD " and device Id %d\n",
      DPxPTR(host_ptr), device_id);
 
   if (device_id == OFFLOAD_DEVICE_DEFAULT) {
     device_id = omp_get_default_device();
   }
 
   if (CheckDevice(device_id) != OFFLOAD_SUCCESS) {
EXTERN int __tgt_target_nowait(int32_t device_id, void *host_ptr,
 
   return __tgt_target(device_id, host_ptr, arg_num, args_base, args, arg_sizes,
                       arg_types);
 }
 
 EXTERN int __tgt_target_teams(int32_t device_id, void *host_ptr,
     int32_t arg_num, void **args_base, void **args, int64_t *arg_sizes,
     int32_t *arg_types, int32_t team_num, int32_t thread_limit) {
-  if (device_id == OFFLOAD_DEVICE_CONSTRUCTOR ||
-      device_id == OFFLOAD_DEVICE_DESTRUCTOR) {
-    // Return immediately for the time being, target calls with device_id
-    // -2 or -3 will be removed from the compiler in the future.
-    return OFFLOAD_SUCCESS;
-  }
-
   DP("Entering target region with entry point " DPxMOD " and device Id %d\n",
      DPxPTR(host_ptr), device_id);
 
   if (device_id == OFFLOAD_DEVICE_DEFAULT) {
     device_id = omp_get_default_device();
   }
 
   if (CheckDevice(device_id) != OFFLOAD_SUCCESS) {