This is an archive of the discontinued LLVM Phabricator instance.

Differential D32311

Check for target(popcnt) capability before usage
ClosedPublic

Authored by george.karpenkov on Apr 20 2017, 2:49 PM.

Details

Reviewers
kcc
Commits
rG9eb170fede34: [libFuzzer] Check for target(popcnt) capability before usage
rL300999: [libFuzzer] Check for target(popcnt) capability before usage
Summary

Older compilers (e.g. LLVM 3.4) do not support the attribute target("popcnt").
In order to support those, this diff check the attribute support using the preprocessor.

Diff Detail

Event Timeline

george.karpenkov created this revision.Apr 20 2017, 2:49 PM
george.karpenkov mentioned this in D32096: Always build libfuzzer.Apr 20 2017, 2:54 PM
kcc accepted this revision.Apr 20 2017, 3:47 PM

LGTM, but please double-check that we get proper attribute in the fresh compiler.

This revision is now accepted and ready to land.Apr 20 2017, 3:47 PM
Closed by commit rL300999: [libFuzzer] Check for target(popcnt) capability before usage (authored by kuba.brecka). · Explain WhyApr 21 2017, 10:10 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Fuzzer/
12 lines

Diff 96024

lib/Fuzzer/FuzzerDefs.h

Show All 30 Lines
#elif _WIN32 #elif _WIN32
#define LIBFUZZER_APPLE 0 #define LIBFUZZER_APPLE 0
#define LIBFUZZER_LINUX 0 #define LIBFUZZER_LINUX 0
#define LIBFUZZER_WINDOWS 1 #define LIBFUZZER_WINDOWS 1
#else #else
#error "Support for your platform has not been implemented" #error "Support for your platform has not been implemented"
#endif #endif
#ifndef __has_attribute
# define __has_attribute(x) 0
#endif
#define LIBFUZZER_POSIX LIBFUZZER_APPLE || LIBFUZZER_LINUX #define LIBFUZZER_POSIX LIBFUZZER_APPLE || LIBFUZZER_LINUX
#ifdef __x86_64 #ifdef __x86_64
# if __has_attribute(target)
#define ATTRIBUTE_TARGET_POPCNT __attribute__((target("popcnt"))) # define ATTRIBUTE_TARGET_POPCNT __attribute__((target("popcnt")))
#else # else
#define ATTRIBUTE_TARGET_POPCNT # define ATTRIBUTE_TARGET_POPCNT
#endif # endif
#else
# define ATTRIBUTE_TARGET_POPCNT
#endif
#ifdef __clang__ // avoid gcc warning. #ifdef __clang__ // avoid gcc warning.
# define ATTRIBUTE_NO_SANITIZE_MEMORY __attribute__((no_sanitize("memory"))) # define ATTRIBUTE_NO_SANITIZE_MEMORY __attribute__((no_sanitize("memory")))
# define ALWAYS_INLINE __attribute__((always_inline)) # define ALWAYS_INLINE __attribute__((always_inline))
#else #else
# define ATTRIBUTE_NO_SANITIZE_MEMORY # define ATTRIBUTE_NO_SANITIZE_MEMORY
# define ALWAYS_INLINE # define ALWAYS_INLINE
▲ Show 20 Lines • Show All 63 Lines • Show Last 20 Lines