This is an archive of the discontinued LLVM Phabricator instance.

Differential D32307

[libcxx] [test] Resolve everyone's favorite warning, unused local typedef
ClosedPublic

Authored by BillyONeal on Apr 20 2017, 1:45 PM.

Details

Reviewers
mclow.lists
EricWF
Summary

Just turned on test/std/strings/basic.string/string.cons/T_size_size.pass.cpp and tripped over this one :)

Diff Detail

Event Timeline

BillyONeal created this revision.Apr 20 2017, 1:45 PM
BillyONeal retitled this revision from Resolve everyone's favorite warning, unused local typedef to [libcxx] [test] Resolve everyone's favorite warning, unused local typedef.Apr 20 2017, 2:04 PM
BillyONeal added a subscriber: cfe-commits.
mclow.lists accepted this revision.Apr 20 2017, 5:45 PM
This revision is now accepted and ready to land.Apr 20 2017, 5:45 PM
BillyONeal closed this revision.Apr 20 2017, 6:23 PM

Committed r300937

Revision Contents

PathSize
test/
std/
strings/
basic.string/
string.cons/
1 line

Diff 96010

test/std/strings/basic.string/string.cons/T_size_size.pass.cpp

Show First 20 Lines • Show All 57 Lines • ▼ Show 20 Lines
#endif #endif
} }
template <class S, class SV> template <class S, class SV>
void void
test(SV sv, unsigned pos, unsigned n, const typename S::allocator_type& a) test(SV sv, unsigned pos, unsigned n, const typename S::allocator_type& a)
{ {
typedef typename S::traits_type T; typedef typename S::traits_type T;
typedef typename S::allocator_type A;
if (pos <= sv.size()) if (pos <= sv.size())
{ {
S s2(sv, pos, n, a); S s2(sv, pos, n, a);
LIBCPP_ASSERT(s2.__invariants()); LIBCPP_ASSERT(s2.__invariants());
assert(pos <= sv.size()); assert(pos <= sv.size());
unsigned rlen = std::min<unsigned>(sv.size() - pos, n); unsigned rlen = std::min<unsigned>(sv.size() - pos, n);
assert(s2.size() == rlen); assert(s2.size() == rlen);
assert(T::compare(s2.data(), sv.data() + pos, rlen) == 0); assert(T::compare(s2.data(), sv.data() + pos, rlen) == 0);
▲ Show 20 Lines • Show All 112 Lines • Show Last 20 Lines