Page MenuHomePhabricator

Recompute ArchSpec core after MergeFrom

Authored by labath on Apr 19 2017, 5:30 AM.



MergeFrom was updating the architecture if the target triple did not
have it set. However, it was leaving the core field as invalid. This
resulted in assertion failures in core file tests as a missing core
meant we were unable to compute the address byte size properly.

Add a unit test for the new behaviour.

Diff Detail


Event Timeline

labath created this revision.Apr 19 2017, 5:30 AM
labath updated this revision to Diff 95722.Apr 19 2017, 5:34 AM

Also remove the skipIfDarwin decorators, as they should work now -- there was
nothing darwin-specific about them, just our bots don't run assert builds at the

clayborg accepted this revision.Apr 19 2017, 8:29 AM
This revision is now accepted and ready to land.Apr 19 2017, 8:29 AM
This revision was automatically updated to reflect the committed changes.