Page MenuHomePhabricator

Teach RenderScriptRuntime about changed context representation.
ClosedPublic

Authored by dgross on Apr 18 2017, 12:20 PM.

Details

Summary

The runtime discovers contexts through RenderScriptRuntime::Capture*()
methods. These methods see the low-level context representation.
However, the runtime calls APIs that require the high-level context
representation. Therefore, it needs to call yet another API to find
the high-level representation associated with a given low-level
representation.

Diff Detail

Repository
rL LLVM

Event Timeline

dgross created this revision.Apr 18 2017, 12:20 PM
labath accepted this revision.Apr 19 2017, 5:39 AM

lgtm. You might consider using llvm::formatv instead of the raw snprintf -- it would make the PRIx64 macros more readable.

This revision is now accepted and ready to land.Apr 19 2017, 5:39 AM
This revision was automatically updated to reflect the committed changes.