This is an archive of the discontinued LLVM Phabricator instance.

[XRay] [compiler-rt] Skip tests that use 'llvm_xray' for standalone builds.
ClosedPublic

Authored by kpw on Apr 17 2017, 7:10 PM.

Details

Summary

Tests that generate output with compiler-rt and verify it with the llvm_xray
command (built from the llvm tree) are extremely convenient, but compiler-rt
can be built out of tree and llvm_xray is not built for every target.

This change intends to disable tests for out of tree builds, but does nothing
to detect whether llvm_xray can be found elsewhere on the path, is fresh enough,
or is part of a build target for the in tree build.

Tested:

Tested that this didn't break check-xray. Haven't reproduced bots or standalone
builds.

Diff Detail

Repository
rL LLVM

Event Timeline

kpw created this revision.Apr 17 2017, 7:10 PM
dberris accepted this revision.Apr 17 2017, 8:12 PM

LGTM -- thanks @kpw!

This revision is now accepted and ready to land.Apr 17 2017, 8:12 PM
This revision was automatically updated to reflect the committed changes.