This is an archive of the discontinued LLVM Phabricator instance.

Ask Python where platform specific lib dir is.
Needs ReviewPublic

Authored by • gmilos on Apr 14 2017, 3:50 AM.

Reviewers

Summary

scripts/CMakeLists.txt
21	I think you should handle the case where this command fails.

@gmilos ping? Are you still looking at this one?

Path

Size

scripts/

11 lines

Context not available.
	include(FindPythonInterp)	include(FindPythonInterp)

	if (NOT CMAKE_SYSTEM_NAME MATCHES "Windows")	if (NOT CMAKE_SYSTEM_NAME MATCHES "Windows")
	set(SWIG_PYTHON_DIR	execute_process(
	${CMAKE_BINARY_DIR}/lib${LLVM_LIBDIR_SUFFIX}/python${PYTHON_VERSION_MAJOR}.${PYTHON_VERSION_MINOR})	COMMAND
		${PYTHON_EXECUTABLE}
		"-c"
		"from __future__ import print_function; from distutils.sysconfig import get_python_lib; \
		print(get_python_lib(True, False, '${CMAKE_BINARY_DIR}'), end='')"
		OUTPUT_VARIABLE SWIG_PYTHON_DIR)
		beanzUnsubmitted Not Done Reply Inline Actions I think you should handle the case where this command fails. beanz: I think you should handle the case where this command fails.
	else()	else()
	set(SWIG_PYTHON_DIR ${CMAKE_BINARY_DIR}/lib${LLVM_LIBDIR_SUFFIX}/site-packages)	set(SWIG_PYTHON_DIR ${CMAKE_BINARY_DIR}/lib${LLVM_LIBDIR_SUFFIX}/site-packages)
	endif()	endif()

	set(SWIG_INSTALL_DIR lib${LLVM_LIBDIR_SUFFIX})	string(REGEX MATCH "lib/\|lib64/" SWIG_INSTALL_DIR ${SWIG_PYTHON_DIR})

	# Generating the LLDB framework correctly is a bit complicated because the	# Generating the LLDB framework correctly is a bit complicated because the
	# framework depends on the swig output.	# framework depends on the swig output.
Context not available.