This is an archive of the discontinued LLVM Phabricator instance.

[Modules] Allow local submodule visibility without c++
ClosedPublic

Authored by bruno on Apr 6 2017, 11:44 AM.

Download Raw Diff

Details

Reviewers

Commits

rGc69f9f3530dc: [Modules] Enable local submodule visibility for ObjC/C
rC300108: [Modules] Enable local submodule visibility for ObjC/C
rL300108: [Modules] Enable local submodule visibility for ObjC/C

Summary

Removing this restriction will make it handy to explore local submodule visibility without c++ being turned on. We're currently testing it out with C/ObjC.

Diff Detail

Event Timeline

bruno created this revision.Apr 6 2017, 11:44 AM

Can you also add a basic test that this works in C? Thanks!

This revision is now accepted and ready to land.Apr 11 2017, 11:37 AM

Closed by commit rL300108: [Modules] Enable local submodule visibility for ObjC/C (authored by bruno). · Explain WhyApr 12 2017, 2:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

lib/

Frontend/

CompilerInvocation.cpp

6 lines

Diff 94407

lib/Frontend/CompilerInvocation.cpp

Context not available.
	Args.hasFlag(OPT_fdeclspec, OPT_fno_declspec,	Args.hasFlag(OPT_fdeclspec, OPT_fno_declspec,
	(Opts.MicrosoftExt \|\| Opts.Borland \|\| Opts.CUDA));	(Opts.MicrosoftExt \|\| Opts.Borland \|\| Opts.CUDA));

	// For now, we only support local submodule visibility in C++ (because we
	// heavily depend on the ODR for merging redefinitions).
	if (Opts.ModulesLocalVisibility && !Opts.CPlusPlus)
	Diags.Report(diag::err_drv_argument_not_allowed_with)
	<< "-fmodules-local-submodule-visibility" << "C";

	if (Arg *A = Args.getLastArg(OPT_faddress_space_map_mangling_EQ)) {	if (Arg *A = Args.getLastArg(OPT_faddress_space_map_mangling_EQ)) {
	switch (llvm::StringSwitch<unsigned>(A->getValue())	switch (llvm::StringSwitch<unsigned>(A->getValue())
	.Case("target", LangOptions::ASMM_Target)	.Case("target", LangOptions::ASMM_Target)
Context not available.