This is an archive of the discontinued LLVM Phabricator instance.

Add a virtual destructor to a class with virtual methods.
ClosedPublic

Authored by krasin on Apr 6 2017, 11:07 AM.

Reviewers

Commits

Summary

Recently, Clang enabled the check for virtual destructors
in the presence of virtual methods. That broke the bootstrap
build. Fixing it.

Build Status

Buildable 5363
Build 5363: arc lint + arc unit

LGTM

This revision is now accepted and ready to land.Apr 6 2017, 11:10 AM

Path

Size

lib/

sanitizer_common/

1 line

	Show All 16 Lines
	#include "sanitizer_internal_defs.h"			#include "sanitizer_internal_defs.h"
	#include "sanitizer_libc.h"			#include "sanitizer_libc.h"
	#include "sanitizer_common.h"			#include "sanitizer_common.h"

	namespace __sanitizer {			namespace __sanitizer {

	class FlagHandlerBase {			class FlagHandlerBase {
	public:			public:
				virtual ~FlagHandlerBase() {}
	virtual bool Parse(const char *value) { return false; }			virtual bool Parse(const char *value) { return false; }
	};			};

	template <typename T>			template <typename T>
	class FlagHandler : public FlagHandlerBase {			class FlagHandler : public FlagHandlerBase {
	T *t_;			T *t_;

	public:			public:
	▲ Show 20 Lines • Show All 90 Lines • Show Last 20 Lines