Page MenuHomePhabricator

[mips] The decision to use MO_GOT_PAGE and MO_GOT_OFST depends on the ABI being N32 or N64 not the arch being MIPS64
ClosedPublic

Authored by dsanders on Mar 25 2014, 8:12 AM.

Details

Summary

No functional change (in supported use cases)

Diff Detail

Event Timeline

matheusalmeida accepted this revision.Mar 26 2014, 3:10 AM

LGTM. Just like D3175, I'm not sure this patch doesn't introduce functional changes because you're changing the way our backend deals with Mips64/O32.

Just like D3175, I'm not sure this patch doesn't introduce functional changes because you're changing the way our backend deals with Mips64/O32.

True, it would affect that case but that's supported yet and is likely to be broken since isMips64() has been used as a synonym for isN32()||isN64() in many places.

... but that's supported yet ...

*not supported

dsanders closed this revision.Mar 26 2014, 7:06 AM