Page MenuHomePhabricator

[mips] The register names depend on the ABI being N32/N64 rather than the arch being mips64
ClosedPublic

Authored by dsanders on Mar 25 2014, 7:12 AM.

Details

Summary

Added test cases for O32 and N32 on MIPS64.

Diff Detail

Event Timeline

matheusalmeida accepted this revision.Mar 25 2014, 10:13 AM

I believe this actually fixes an existing bug. It's valid to have Mips64/O32 which means the old code was incrementing the register number by 4 when it shouldn't [-mabi=32].

LGTM.

dsanders updated this revision to Unknown Object (????).Mar 26 2014, 4:26 AM
  • Renamed tests to include ABI names
  • Added testcase for O32 on MIPS64.
dsanders closed this revision.Mar 26 2014, 4:46 AM