This is an archive of the discontinued LLVM Phabricator instance.

Differential D31618

Don't remove the cwd
ClosedPublic

Authored by • rafael on Apr 3 2017, 12:36 PM.

Details

Reviewers
filcab
rnk
Summary

This works with a regular shell since the kernel can keep track of a deleted cwd. Since we just keep a path string, the following suppresses invocations fail.

I think this would also fail on windows.

Diff Detail

Event Timeline

• rafael created this revision.Apr 3 2017, 12:36 PM
Herald added a subscriber: kubamracek. · View Herald TranscriptApr 3 2017, 12:36 PM
rnk accepted this revision.Apr 3 2017, 2:55 PM

lgtm

This revision is now accepted and ready to land.Apr 3 2017, 2:55 PM
• rafael closed this revision.Apr 4 2017, 2:59 PM

Revision Contents

PathSize
compiler-rt/
test/
asan/
TestCases/
Linux/
1 line

Diff 93921

compiler-rt/test/asan/TestCases/Linux/coverage-missing.cc

Show All 23 Lines
// lists can be tested for set inclusion with diff + grep. // lists can be tested for set inclusion with diff + grep.
// RUN: ( diff bar.txt foo-missing-with-main.txt || true ) | not grep "^<" // RUN: ( diff bar.txt foo-missing-with-main.txt || true ) | not grep "^<"
// Second case: coverage from DSO. // Second case: coverage from DSO.
// cd %T // cd %T
// RUN: %clangxx_asan -fsanitize-coverage=func %s -o %dynamiclib -DFOOBAR -shared -fPIC // RUN: %clangxx_asan -fsanitize-coverage=func %s -o %dynamiclib -DFOOBAR -shared -fPIC
// RUN: %clangxx_asan -fsanitize-coverage=func %s %dynamiclib -o %t -DMAIN // RUN: %clangxx_asan -fsanitize-coverage=func %s %dynamiclib -o %t -DMAIN
// RUN: export LIBNAME=`basename %dynamiclib` // RUN: export LIBNAME=`basename %dynamiclib`
// RUN: cd ..
// RUN: rm -rf %T/coverage-missing // RUN: rm -rf %T/coverage-missing
// RUN: mkdir -p %T/coverage-missing // RUN: mkdir -p %T/coverage-missing
// RUN: cd %T/coverage-missing // RUN: cd %T/coverage-missing
// RUN: %env_asan_opts=coverage=1:coverage_dir=%T/coverage-missing %run %t x // RUN: %env_asan_opts=coverage=1:coverage_dir=%T/coverage-missing %run %t x
// RUN: %sancov print $LIBNAME.*.sancov > foo.txt // RUN: %sancov print $LIBNAME.*.sancov > foo.txt
// RUN: rm *.sancov // RUN: rm *.sancov
// RUN: count 2 < foo.txt // RUN: count 2 < foo.txt
// RUN: %env_asan_opts=coverage=1:coverage_dir=%T/coverage-missing %run %t x x // RUN: %env_asan_opts=coverage=1:coverage_dir=%T/coverage-missing %run %t x x
▲ Show 20 Lines • Show All 43 Lines • Show Last 20 Lines