This is an archive of the discontinued LLVM Phabricator instance.

Use os.path.realpath when tracking the cwd
ClosedPublic

Authored by rafael on Mar 30 2017, 8:38 AM.

Details

Summary

This is needed by TestCases/Posix/coverage-direct.cc

The problem is that the test does:

mkdir <dir>
cd <dir>
cd ..
rm -rf <dir>
<more commands>

the current directory currently looks like "/.../<dir>/../" which doesn't exist when dir is deleted.

at some point we should probably switch to using the os current directory (specially if we want to add subshell), but this is a small incremental improvement.

Diff Detail

Event Timeline

rafael created this revision.Mar 30 2017, 8:38 AM
rnk accepted this revision.Mar 30 2017, 12:53 PM

lgtm

This revision is now accepted and ready to land.Mar 30 2017, 12:53 PM
rafael closed this revision.Mar 30 2017, 2:18 PM