This is an archive of the discontinued LLVM Phabricator instance.

Re-enable assertion after the problem that caused it to be hit had been fixed.
ClosedPublic

Authored by AndreyChurbanov on Mar 28 2017, 7:37 AM.

Details

Summary

The problem of inconsistent pointers to task team in the thread and team structures had been fixed by the commit r249711 (https://reviews.llvm.org/D13353).

Thus the debug assertion can safely be restored.

Tried the test provided in the https://reviews.llvm.org/D11269 which disabled the assertion. That test caused the assertion before r249711, and it work fine now. Not sure if we can add the test for regression testing because it only makes sense on a debug library.

Diff Detail

Repository
rL LLVM

Event Timeline

jlpeyton accepted this revision.May 22 2017, 11:32 AM
This revision is now accepted and ready to land.May 22 2017, 11:32 AM
This revision was automatically updated to reflect the committed changes.