This is an archive of the discontinued LLVM Phabricator instance.

[PDB] Split item and type records when merging type streams
ClosedPublic

Authored by rnk on Mar 23 2017, 5:52 PM.

Event Timeline

rnk created this revision.Mar 23 2017, 5:52 PM
ruiu accepted this revision.Mar 23 2017, 6:01 PM

LGTM. Only a minor cosmetic comments.

lld/COFF/PDB.cpp
97

Remove llvm::.

216

nit: write it in two lines.

llvm/tools/llvm-readobj/ObjDumper.h
13

Do you need this?

This revision is now accepted and ready to land.Mar 23 2017, 6:01 PM
rnk marked 2 inline comments as done.Mar 24 2017, 10:13 AM
rnk added inline comments.
lld/COFF/PDB.cpp
118

Remove llvm:: here as well?

llvm/tools/llvm-readobj/ObjDumper.h
13

Not anymore.

This revision was automatically updated to reflect the committed changes.