[OpenMP] CUDA plugin: More descriptive error messages

[grokos]

Summary

When a kernel execution fails, the CUDA plugin prints a more descriptive message about the nature of the failure.

[Hahnfeld]

libomptarget/plugins/cuda/src/rtl.cpp

652 ↗

(On Diff #92536)

You might want to use cudaGetErrorString(sync_error) here to fulfill %s?

[grokos]

Updated diff.

libomptarget/plugins/cuda/src/rtl.cpp

652 ↗

(On Diff #92536)

Correct, done in new diff.

[Hahnfeld]

LGTM

openmp/trunk/libomptarget/plugins/cuda/src/rtl.cpp

if (err != CUDA_SUCCESS) {
     CUDA_ERR_STRING(err);
     assert(err == CUDA_SUCCESS && "Unable to launch target execution!");
     return OFFLOAD_FAIL;
   }
 
   DP("Launch of entry point at " DPxMOD " successful!\n",
       DPxPTR(tgt_entry_ptr));
 
-  if (cudaDeviceSynchronize() != cudaSuccess) {
-    DP("Kernel execution error at " DPxMOD ".\n", DPxPTR(tgt_entry_ptr));
+  cudaError_t sync_error = cudaDeviceSynchronize();
+  if (sync_error != cudaSuccess) {
+  DP("Kernel execution error at " DPxMOD ", %s.\n", DPxPTR(tgt_entry_ptr),
+      cudaGetErrorString(sync_error));
     return OFFLOAD_FAIL;
   } else {
     DP("Kernel execution at " DPxMOD " successful!\n", DPxPTR(tgt_entry_ptr));
   }
 
   return OFFLOAD_SUCCESS;
 }