Page MenuHomePhabricator

[X86][MS-compatability] allow MS TYPE/SIZE/LENGTH operators as a part of a compound expression
ClosedPublic

Authored by coby on Mar 21 2017, 12:52 AM.

Details

Summary

This patch introduces X86AsmParser with the ability to handle the aforementioned ops within compound "MS" arithmetical expressions. Currently - only supported as a stand alone Operand, e.g.:
"TYPE X"
now allowed :
"4 + TYPE X * 128"

Clang side: https://reviews.llvm.org/D31174

Diff Detail

Repository
rL LLVM

Event Timeline

coby created this revision.Mar 21 2017, 12:52 AM
coby edited the summary of this revision. (Show Details)Mar 21 2017, 12:54 AM
rnk accepted this revision.Mar 21 2017, 10:10 AM

lgtm

lib/Target/X86/AsmParser/X86AsmParser.cpp
1791–1792 ↗(On Diff #92436)

Add FIXME: here, since this should be addressed eventually.

This revision is now accepted and ready to land.Mar 21 2017, 10:10 AM
This revision was automatically updated to reflect the committed changes.