[ELF] - Detemplate MipsGotSection<ELFT>
ClosedPublic

Authored by grimar on Fri, Mar 17, 10:49 AM.

Details

Summary

This continues detemplation process.

Detemplating MipsGotSection<ELFT> is helpfull because can
help to detemplate getRelocTargetVA. (one more change is required)
It opens road to detemplation of GotSection<ELFT> and probably
something else after that.

Diff Detail

Repository
rL LLVM
grimar created this revision.Fri, Mar 17, 10:49 AM
atanasyan accepted this revision.Fri, Mar 17, 11:04 AM

LGTM. Thanks.

This revision is now accepted and ready to land.Fri, Mar 17, 11:04 AM
ruiu added inline comments.Fri, Mar 17, 11:42 AM
ELF/Config.h
170 ↗(On Diff #92168)

This is a sort of unrelated refactoring, so let's not do this in this patch. (Besides size is not a good name.)

214 ↗(On Diff #92168)

I think endianness::little and endianness::bit are silly because there are only two endianness. This should return true or false. Can you rename this isLE and returns if it is a little endian?

ruiu added inline comments.Fri, Mar 17, 4:40 PM
ELF/Config.h
170 ↗(On Diff #92168)

I added Config->Wordsize, so please use it.

grimar updated this revision to Diff 92307.Mon, Mar 20, 2:54 AM
  • Addressed review comments.
ruiu accepted this revision.Mon, Mar 20, 8:08 AM

LGTM

This revision was automatically updated to reflect the committed changes.