This fixes a race condition where another linker process can observe a
partially written file if we copy it from another file system, and allows
the link to be independent of the amount of free disk space in $TMPDIR.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
That's nice! LGTM.
I wonder though if we shouldn't have the cache pruning take a "blacklist" of patterns and ignore these files. I wouldn't want one linker process to delete temporary files from another one (Unlikely to happen I guess since LRU though).
Comment Actions
Probably the simplest thing we could do to avoid this problem is to create the temporaries in a subdirectory of the cache directory, and have the pruning ignore subdirectories. I agree with you that this is unlikely though.