This is an archive of the discontinued LLVM Phabricator instance.

[ELF] - Combine LinkerScriptBase and LinkerScript<ELFT>
ClosedPublic

Authored by grimar on Mar 15 2017, 7:24 AM.

Details

Summary

Patch removes templated linkerscript class.

Unfortunately that required 2 additional static methods
findSymbol() and addRegularSymbol() because code
depends on Symtab<ELFT>::X

But that seems enough. I wonder if it is possible to avoid though.

Diff Detail

Event Timeline

grimar created this revision.Mar 15 2017, 7:24 AM
grimar retitled this revision from [ELF] - REmove virtual methods from linker script class. to [ELF] - Remove virtual methods from linker script class..
grimar updated this revision to Diff 91882.Mar 15 2017, 9:03 AM
grimar edited the summary of this revision. (Show Details)
  • Rebased.
grimar planned changes to this revision.Mar 16 2017, 9:24 AM

I will update it later after landing another detemplating patches.

grimar updated this revision to Diff 92155.Mar 17 2017, 9:43 AM
grimar retitled this revision from [ELF] - Remove virtual methods from linker script class. to [ELF] - Combine LinkerScriptBase and LinkerScript<ELFT>.
grimar edited the summary of this revision. (Show Details)
  • Updated.
grimar added inline comments.Mar 17 2017, 9:44 AM
ELF/LinkerScript.h
311

Also LinkerScriptBase should probably be renamed to LinkerScript, but I did not do that now to reduce amount of changes.

ruiu accepted this revision.Mar 17 2017, 12:30 PM

LGTM

ELF/LinkerScript.cpp
1749–1750

Unrelated format change?

This revision is now accepted and ready to land.Mar 17 2017, 12:30 PM
This revision was automatically updated to reflect the committed changes.