Differential D30929

NewGVN: Handle coercion of constant stores, loads, memory insts.
ClosedPublic
Actions

Authored by • dberlin on Mar 13 2017, 10:03 PM.

Details

Reviewers

davide

Commits

rL299330: NewGVN: Handle coercion of constant stores, loads, memory insts.

Summary

Depends on D30928.

This adds support for coercion of stores and memory instructions that do not require insertion to process.
Another few tests down.
I added the relevant tests from rle.ll

Diff Detail

Repository: rL LLVM

Event Timeline

• dberlin created this revision.Mar 13 2017, 10:03 PM

Herald added a subscriber: Prazek. · View Herald TranscriptMar 13 2017, 10:03 PM

• dberlin added inline comments.Mar 13 2017, 10:05 PM

lib/Transforms/Scalar/NewGVN.cpp
814 ↗	(On Diff #91677)	i'll fix the comment formatting.
818 ↗	(On Diff #91677)	waiting on a bootstrap to check this.
829 ↗	(On Diff #91677)	and this :)

Update to fix bugs discovered during a few 3-stages

Closed by commit rL299330: NewGVN: Handle coercion of constant stores, loads, memory insts. (authored by dannyb). · Explain WhyApr 2 2017, 6:36 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp (94 lines)
M			llvm/trunk/test/Transforms/NewGVN/calloc-load-removal.ll (1 line)
M			llvm/trunk/test/Transforms/NewGVN/fold-const-expr.ll (1 line)
M			llvm/trunk/test/Transforms/NewGVN/malloc-load-removal.ll (1 line)
M			llvm/trunk/test/Transforms/NewGVN/pr17732.ll (2 lines)
M			llvm/trunk/test/Transforms/NewGVN/rle.ll (59 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	91677	297704		Mar 13 2017, 10:03 PM	★	★
Diff 2	91681	297704	Update to fix bugs discovered during a few 3-stages	Mar 14 2017, 1:25 AM	★	★
Diff 3	93779	299329	rL299330	Apr 2 2017, 6:23 AM	★	★

	Status	Author	Revision
	Closed	• dberlin	D30929 NewGVN: Handle coercion of constant stores, loads, memory insts.
	Closed	• dberlin	D30928 Templatize parts of VNCoercion, and add constant-only versions of the functions to be used in NewGVN. NFCI.