This is an archive of the discontinued LLVM Phabricator instance.

Reexport operator new / delete from libc++abi
ClosedPublic

Authored by mehdi_amini on Mar 8 2017, 3:43 PM.

Download Raw Diff

Details

Reviewers

Commits

rG87e8e25548d7: Reexport operator new / delete from libc++abi
rCXX299054: Reexport operator new / delete from libc++abi
rL299054: Reexport operator new / delete from libc++abi

Summary

Both libc++ and libc++abi export a weak definition of operator
new/delete. On Darwin, this can often cause dirty __DATA in the
shared cache when having to switch from one to the other. Instead,
libc++ should reexport libc++abi's implementation of these symbols.

Patch by: Ted Kremenek <kremenek@apple.com>

Diff Detail

Repository: rL LLVM

Event Timeline

mehdi_amini created this revision.Mar 8 2017, 3:43 PM

Harbormaster completed remote builds in B4640: Diff 91091.Mar 8 2017, 3:43 PM

Herald edited edge metadata. · View Herald TranscriptMar 8 2017, 3:43 PM

Note: this is already shipping like this for ~2 years in our OSes.

LGTM. We'll hear soon enough if this starts causing problems.

This revision is now accepted and ready to land.Mar 22 2017, 7:36 PM

mehdi_amini added a parent revision: D31272: Do not pass an explicit reexported symbol list when building libc++ dylib if also defining new/delete.Mar 28 2017, 12:43 PM

Closed by commit rL299054: Reexport operator new / delete from libc++abi (authored by mehdi_amini). · Explain WhyMar 29 2017, 9:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

libcxx/

trunk/

lib/

libc++abi2.exp

16 lines

Diff 93445

libcxx/trunk/lib/libc++abi2.exp

	Show First 20 Lines • Show All 203 Lines • ▼ Show 20 Lines
	__ZNSt10bad_typeidD0Ev			__ZNSt10bad_typeidD0Ev
	__ZNSt10bad_typeidD2Ev			__ZNSt10bad_typeidD2Ev
	__ZNSt13bad_exceptionD0Ev			__ZNSt13bad_exceptionD0Ev
	__ZNSt13bad_exceptionD2Ev			__ZNSt13bad_exceptionD2Ev
	__ZNSt20bad_array_new_lengthC2Ev			__ZNSt20bad_array_new_lengthC2Ev
	__ZNSt20bad_array_new_lengthD0Ev			__ZNSt20bad_array_new_lengthD0Ev
	__ZNSt20bad_array_new_lengthD2Ev			__ZNSt20bad_array_new_lengthD2Ev
	__ZSt10unexpectedv			__ZSt10unexpectedv
	# __ZdaPv			__ZdaPv
	# __ZdlPv			__ZdlPv
	# __ZdlPvRKSt9nothrow_t			__ZdlPvRKSt9nothrow_t
	# __Znam			__Znam
	# __ZdaPvRKSt9nothrow_t			__ZdaPvRKSt9nothrow_t
	# __Znwm			__Znwm
	# __ZnwmRKSt9nothrow_t			__ZnwmRKSt9nothrow_t
	# __ZnamRKSt9nothrow_t			__ZnamRKSt9nothrow_t
	__ZTISt10bad_typeid			__ZTISt10bad_typeid
	__ZTISt8bad_cast			__ZTISt8bad_cast
	___cxa_bad_typeid			___cxa_bad_typeid
	___cxa_bad_cast			___cxa_bad_cast
	__ZTISt9exception			__ZTISt9exception
	__ZTISt9type_info			__ZTISt9type_info
	__ZTISt20bad_array_new_length			__ZTISt20bad_array_new_length

	▲ Show 20 Lines • Show All 93 Lines • Show Last 20 Lines