This is an archive of the discontinued LLVM Phabricator instance.

Differential D3070

Generalise assembly tests to not rely on anonymous symbol names
ClosedPublic

Authored by olista01 on Mar 13 2014, 8:42 AM.

Details

Reviewers
echristo
• rafael

Diff Detail

Event Timeline

• rafael accepted this revision.Mar 13 2014, 9:25 AM

LGTM

echristo accepted this revision.Mar 13 2014, 11:14 AM

LGTM.

olista01 closed this revision.Mar 14 2014, 2:17 AM

Committed revision 203909.

Revision Contents

PathSize
test/
MC/
ARM/
64 lines
24 lines

Diff 7800

test/MC/ARM/ldr-pseudo.s

Show All 10 Lines
@ @
@ Check that large constants are converted to ldr from constant pool @ Check that large constants are converted to ldr from constant pool
@ @
@ simple test @ simple test
.section b,"ax",%progbits .section b,"ax",%progbits
@ CHECK-LABEL: f3: @ CHECK-LABEL: f3:
f3: f3:
ldr r0, =0x10001 ldr r0, =0x10001
@ CHECK: ldr r0, .Ltmp0 @ CHECK: ldr r0, .Ltmp[[TMP0:[0-9]+]]
@ loading multiple constants @ loading multiple constants
.section c,"ax",%progbits .section c,"ax",%progbits
@ CHECK-LABEL: f4: @ CHECK-LABEL: f4:
f4: f4:
ldr r0, =0x10002 ldr r0, =0x10002
@ CHECK: ldr r0, .Ltmp1 @ CHECK: ldr r0, .Ltmp[[TMP1:[0-9]+]]
adds r0, r0, #1 adds r0, r0, #1
adds r0, r0, #1 adds r0, r0, #1
adds r0, r0, #1 adds r0, r0, #1
adds r0, r0, #1 adds r0, r0, #1
ldr r0, =0x10003 ldr r0, =0x10003
@ CHECK: ldr r0, .Ltmp2 @ CHECK: ldr r0, .Ltmp[[TMP2:[0-9]+]]
adds r0, r0, #1 adds r0, r0, #1
adds r0, r0, #1 adds r0, r0, #1
@ TODO: the same constants should have the same constant pool location @ TODO: the same constants should have the same constant pool location
.section d,"ax",%progbits .section d,"ax",%progbits
@ CHECK-LABEL: f5: @ CHECK-LABEL: f5:
f5: f5:
ldr r0, =0x10004 ldr r0, =0x10004
@ CHECK: ldr r0, .Ltmp3 @ CHECK: ldr r0, .Ltmp[[TMP3:[0-9]+]]
adds r0, r0, #1 adds r0, r0, #1
adds r0, r0, #1 adds r0, r0, #1
adds r0, r0, #1 adds r0, r0, #1
adds r0, r0, #1 adds r0, r0, #1
adds r0, r0, #1 adds r0, r0, #1
adds r0, r0, #1 adds r0, r0, #1
adds r0, r0, #1 adds r0, r0, #1
ldr r0, =0x10004 ldr r0, =0x10004
@ CHECK: ldr r0, .Ltmp4 @ CHECK: ldr r0, .Ltmp[[TMP4:[0-9]+]]
adds r0, r0, #1 adds r0, r0, #1
adds r0, r0, #1 adds r0, r0, #1
adds r0, r0, #1 adds r0, r0, #1
adds r0, r0, #1 adds r0, r0, #1
adds r0, r0, #1 adds r0, r0, #1
adds r0, r0, #1 adds r0, r0, #1
@ a section defined in multiple pieces should be merged and use a single constant pool @ a section defined in multiple pieces should be merged and use a single constant pool
.section e,"ax",%progbits .section e,"ax",%progbits
@ CHECK-LABEL: f6: @ CHECK-LABEL: f6:
f6: f6:
ldr r0, =0x10006 ldr r0, =0x10006
@ CHECK: ldr r0, .Ltmp5 @ CHECK: ldr r0, .Ltmp[[TMP5:[0-9]+]]
adds r0, r0, #1 adds r0, r0, #1
adds r0, r0, #1 adds r0, r0, #1
adds r0, r0, #1 adds r0, r0, #1
.section f, "ax", %progbits .section f, "ax", %progbits
@ CHECK-LABEL: f7: @ CHECK-LABEL: f7:
f7: f7:
adds r0, r0, #1 adds r0, r0, #1
adds r0, r0, #1 adds r0, r0, #1
adds r0, r0, #1 adds r0, r0, #1
.section e, "ax", %progbits .section e, "ax", %progbits
@ CHECK-LABEL: f8: @ CHECK-LABEL: f8:
f8: f8:
adds r0, r0, #1 adds r0, r0, #1
ldr r0, =0x10007 ldr r0, =0x10007
@ CHECK: ldr r0, .Ltmp6 @ CHECK: ldr r0, .Ltmp[[TMP6:[0-9]+]]
adds r0, r0, #1 adds r0, r0, #1
adds r0, r0, #1 adds r0, r0, #1
@ @
@ Check that symbols can be loaded using ldr pseudo @ Check that symbols can be loaded using ldr pseudo
@ @
@ load an undefined symbol @ load an undefined symbol
.section g,"ax",%progbits .section g,"ax",%progbits
@ CHECK-LABEL: f9: @ CHECK-LABEL: f9:
f9: f9:
ldr r0, =foo ldr r0, =foo
@ CHECK: ldr r0, .Ltmp7 @ CHECK: ldr r0, .Ltmp[[TMP7:[0-9]+]]
@ load a symbol from another section @ load a symbol from another section
.section h,"ax",%progbits .section h,"ax",%progbits
@ CHECK-LABEL: f10: @ CHECK-LABEL: f10:
f10: f10:
ldr r0, =f5 ldr r0, =f5
@ CHECK: ldr r0, .Ltmp8 @ CHECK: ldr r0, .Ltmp[[TMP8:[0-9]+]]
@ load a symbol from the same section @ load a symbol from the same section
.section i,"ax",%progbits .section i,"ax",%progbits
@ CHECK-LABEL: f11: @ CHECK-LABEL: f11:
f11: f11:
ldr r0, =f12 ldr r0, =f12
@ CHECK: ldr r0, .Ltmp9 @ CHECK: ldr r0, .Ltmp[[TMP9:[0-9]+]]
@ CHECK-LABEL: f12: @ CHECK-LABEL: f12:
f12: f12:
adds r0, r0, #1 adds r0, r0, #1
adds r0, r0, #1 adds r0, r0, #1
.section j,"ax",%progbits .section j,"ax",%progbits
@ mix of symbols and constants @ mix of symbols and constants
@ CHECK-LABEL: f13: @ CHECK-LABEL: f13:
f13: f13:
adds r0, r0, #1 adds r0, r0, #1
adds r0, r0, #1 adds r0, r0, #1
ldr r0, =0x101 ldr r0, =0x101
@ CHECK: ldr r0, .Ltmp10 @ CHECK: ldr r0, .Ltmp[[TMP10:[0-9]+]]
adds r0, r0, #1 adds r0, r0, #1
adds r0, r0, #1 adds r0, r0, #1
ldr r0, =bar ldr r0, =bar
@ CHECK: ldr r0, .Ltmp11 @ CHECK: ldr r0, .Ltmp[[TMP11:[0-9]+]]
adds r0, r0, #1 adds r0, r0, #1
adds r0, r0, #1 adds r0, r0, #1
@ @
@ Check for correct usage in other contexts @ Check for correct usage in other contexts
@ @
@ usage in macro @ usage in macro
.macro useit_in_a_macro .macro useit_in_a_macro
ldr r0, =0x10008 ldr r0, =0x10008
ldr r0, =baz ldr r0, =baz
.endm .endm
.section k,"ax",%progbits .section k,"ax",%progbits
@ CHECK-LABEL: f14: @ CHECK-LABEL: f14:
f14: f14:
useit_in_a_macro useit_in_a_macro
@ CHECK: ldr r0, .Ltmp12 @ CHECK: ldr r0, .Ltmp[[TMP12:[0-9]+]]
@ CHECK: ldr r0, .Ltmp13 @ CHECK: ldr r0, .Ltmp[[TMP13:[0-9]+]]
@ usage with expressions @ usage with expressions
.section l, "ax", %progbits .section l, "ax", %progbits
@ CHECK-LABEL: f15: @ CHECK-LABEL: f15:
f15: f15:
ldr r0, =0x10001+8 ldr r0, =0x10001+8
@ CHECK: ldr r0, .Ltmp14 @ CHECK: ldr r0, .Ltmp[[TMP14:[0-9]+]]
adds r0, r0, #1 adds r0, r0, #1
ldr r0, =bar+4 ldr r0, =bar+4
@ CHECK: ldr r0, .Ltmp15 @ CHECK: ldr r0, .Ltmp[[TMP15:[0-9]+]]
adds r0, r0, #1 adds r0, r0, #1
@ @
@ Constant Pools @ Constant Pools
@ @
@ CHECK: .section b,"ax",%progbits @ CHECK: .section b,"ax",%progbits
@ CHECK: .align 2 @ CHECK: .align 2
@ CHECK-LABEL: .Ltmp0: @ CHECK: .Ltmp[[TMP0]]
@ CHECK: .long 65537 @ CHECK: .long 65537
@ CHECK: .section c,"ax",%progbits @ CHECK: .section c,"ax",%progbits
@ CHECK: .align 2 @ CHECK: .align 2
@ CHECK-LABEL: .Ltmp1: @ CHECK: .Ltmp[[TMP1]]
@ CHECK: .long 65538 @ CHECK: .long 65538
@ CHECK-LABEL: .Ltmp2: @ CHECK: .Ltmp[[TMP2]]
@ CHECK: .long 65539 @ CHECK: .long 65539
@ CHECK: .section d,"ax",%progbits @ CHECK: .section d,"ax",%progbits
@ CHECK: .align 2 @ CHECK: .align 2
@ CHECK-LABEL: .Ltmp3: @ CHECK: .Ltmp[[TMP3]]
@ CHECK: .long 65540 @ CHECK: .long 65540
@ CHECK-LABEL: .Ltmp4: @ CHECK: .Ltmp[[TMP4]]
@ CHECK: .long 65540 @ CHECK: .long 65540
@ CHECK: .section e,"ax",%progbits @ CHECK: .section e,"ax",%progbits
@ CHECK: .align 2 @ CHECK: .align 2
@ CHECK-LABEL: .Ltmp5: @ CHECK: .Ltmp[[TMP5]]
@ CHECK: .long 65542 @ CHECK: .long 65542
@ CHECK-LABEL: .Ltmp6: @ CHECK: .Ltmp[[TMP6]]
@ CHECK: .long 65543 @ CHECK: .long 65543
@ Should not switch to section because it has no constant pool @ Should not switch to section because it has no constant pool
@ CHECK-NOT: .section f,"ax",%progbits @ CHECK-NOT: .section f,"ax",%progbits
@ CHECK: .section g,"ax",%progbits @ CHECK: .section g,"ax",%progbits
@ CHECK: .align 2 @ CHECK: .align 2
@ CHECK-LABEL: .Ltmp7: @ CHECK: .Ltmp[[TMP7]]
@ CHECK: .long foo @ CHECK: .long foo
@ CHECK: .section h,"ax",%progbits @ CHECK: .section h,"ax",%progbits
@ CHECK: .align 2 @ CHECK: .align 2
@ CHECK-LABEL: .Ltmp8: @ CHECK: .Ltmp[[TMP8]]
@ CHECK: .long f5 @ CHECK: .long f5
@ CHECK: .section i,"ax",%progbits @ CHECK: .section i,"ax",%progbits
@ CHECK: .align 2 @ CHECK: .align 2
@ CHECK-LABEL: .Ltmp9: @ CHECK: .Ltmp[[TMP9]]
@ CHECK: .long f12 @ CHECK: .long f12
@ CHECK: .section j,"ax",%progbits @ CHECK: .section j,"ax",%progbits
@ CHECK: .align 2 @ CHECK: .align 2
@ CHECK-LABEL: .Ltmp10: @ CHECK: .Ltmp[[TMP10]]
@ CHECK: .long 257 @ CHECK: .long 257
@ CHECK-LABEL: .Ltmp11: @ CHECK: .Ltmp[[TMP11]]
@ CHECK: .long bar @ CHECK: .long bar
@ CHECK: .section k,"ax",%progbits @ CHECK: .section k,"ax",%progbits
@ CHECK: .align 2 @ CHECK: .align 2
@ CHECK-LABEL: .Ltmp12: @ CHECK: .Ltmp[[TMP12]]
@ CHECK: .long 65544 @ CHECK: .long 65544
@ CHECK-LABEL: .Ltmp13: @ CHECK: .Ltmp[[TMP13]]
@ CHECK: .long baz @ CHECK: .long baz
@ CHECK: .section l,"ax",%progbits @ CHECK: .section l,"ax",%progbits
@ CHECK: .align 2 @ CHECK: .align 2
@ CHECK-LABEL: .Ltmp14: @ CHECK: .Ltmp[[TMP14]]
@ CHECK: .long 65545 @ CHECK: .long 65545
@ CHECK-LABEL: .Ltmp15: @ CHECK: .Ltmp[[TMP15]]
@ CHECK: .long bar+4 @ CHECK: .long bar+4

test/MC/ARM/ltorg.s

@ This test has a partner (ltorg-darwin.s) that contains matching @ This test has a partner (ltorg-darwin.s) that contains matching
@ tests for the .ltorg on darwin targets. We need separate files @ tests for the .ltorg on darwin targets. We need separate files
@ because the syntax for switching sections and temporary labels differs @ because the syntax for switching sections and temporary labels differs
@ between darwin and linux. Any tests added here should have a matching @ between darwin and linux. Any tests added here should have a matching
@ test added there. @ test added there.
@RUN: llvm-mc -triple armv7-unknown-linux-gnueabi %s | FileCheck %s @RUN: llvm-mc -triple armv7-unknown-linux-gnueabi %s | FileCheck %s
@RUN: llvm-mc -triple thumbv5-unknown-linux-gnueabi %s | FileCheck %s @RUN: llvm-mc -triple thumbv5-unknown-linux-gnueabi %s | FileCheck %s
@RUN: llvm-mc -triple thumbv7-unknown-linux-gnueabi %s | FileCheck %s @RUN: llvm-mc -triple thumbv7-unknown-linux-gnueabi %s | FileCheck %s
@ check that ltorg dumps the constant pool at the current location @ check that ltorg dumps the constant pool at the current location
.section a,"ax",%progbits .section a,"ax",%progbits
@ CHECK-LABEL: f2: @ CHECK-LABEL: f2:
f2: f2:
ldr r0, =0x10001 ldr r0, =0x10001
@ CHECK: ldr r0, .Ltmp0 @ CHECK: ldr r0, .Ltmp[[TMP0:[0-9+]]]
adds r0, r0, #1 adds r0, r0, #1
adds r0, r0, #1 adds r0, r0, #1
b f3 b f3
.ltorg .ltorg
@ constant pool @ constant pool
@ CHECK: .align 2 @ CHECK: .align 2
@ CHECK-LABEL: .Ltmp0: @ CHECK: .Ltmp[[TMP0]]
@ CHECK: .long 65537 @ CHECK: .long 65537
@ CHECK-LABEL: f3: @ CHECK-LABEL: f3:
f3: f3:
adds r0, r0, #1 adds r0, r0, #1
adds r0, r0, #1 adds r0, r0, #1
@ check that ltorg clears the constant pool after dumping it @ check that ltorg clears the constant pool after dumping it
.section b,"ax",%progbits .section b,"ax",%progbits
@ CHECK-LABEL: f4: @ CHECK-LABEL: f4:
f4: f4:
ldr r0, =0x10002 ldr r0, =0x10002
@ CHECK: ldr r0, .Ltmp1 @ CHECK: ldr r0, .Ltmp[[TMP1:[0-9+]]]
adds r0, r0, #1 adds r0, r0, #1
adds r0, r0, #1 adds r0, r0, #1
b f5 b f5
.ltorg .ltorg
@ constant pool @ constant pool
@ CHECK: .align 2 @ CHECK: .align 2
@ CHECK-LABEL: .Ltmp1: @ CHECK: .Ltmp[[TMP1]]
@ CHECK: .long 65538 @ CHECK: .long 65538
@ CHECK-LABEL: f5: @ CHECK-LABEL: f5:
f5: f5:
adds r0, r0, #1 adds r0, r0, #1
adds r0, r0, #1 adds r0, r0, #1
ldr r0, =0x10003 ldr r0, =0x10003
@ CHECK: ldr r0, .Ltmp2 @ CHECK: ldr r0, .Ltmp[[TMP2:[0-9+]]]
adds r0, r0, #1 adds r0, r0, #1
b f6 b f6
.ltorg .ltorg
@ constant pool @ constant pool
@ CHECK: .align 2 @ CHECK: .align 2
@ CHECK-LABEL: .Ltmp2: @ CHECK: .Ltmp[[TMP2]]
@ CHECK: .long 65539 @ CHECK: .long 65539
@ CHECK-LABEL: f6: @ CHECK-LABEL: f6:
f6: f6:
adds r0, r0, #1 adds r0, r0, #1
adds r0, r0, #1 adds r0, r0, #1
@ check that ltorg does not issue an error if there is no constant pool @ check that ltorg does not issue an error if there is no constant pool
.section c,"ax",%progbits .section c,"ax",%progbits
@ CHECK-LABEL: f7: @ CHECK-LABEL: f7:
f7: f7:
adds r0, r0, #1 adds r0, r0, #1
b f8 b f8
.ltorg .ltorg
f8: f8:
adds r0, r0, #1 adds r0, r0, #1
@ check that ltorg works for labels @ check that ltorg works for labels
.section d,"ax",%progbits .section d,"ax",%progbits
@ CHECK-LABEL: f9: @ CHECK-LABEL: f9:
f9: f9:
adds r0, r0, #1 adds r0, r0, #1
adds r0, r0, #1 adds r0, r0, #1
ldr r0, =bar ldr r0, =bar
@ CHECK: ldr r0, .Ltmp3 @ CHECK: ldr r0, .Ltmp[[TMP3:[0-9+]]]
adds r0, r0, #1 adds r0, r0, #1
adds r0, r0, #1 adds r0, r0, #1
adds r0, r0, #1 adds r0, r0, #1
b f10 b f10
.ltorg .ltorg
@ constant pool @ constant pool
@ CHECK: .align 2 @ CHECK: .align 2
@ CHECK-LABEL: .Ltmp3: @ CHECK: .Ltmp[[TMP3]]
@ CHECK: .long bar @ CHECK: .long bar
@ CHECK-LABEL: f10: @ CHECK-LABEL: f10:
f10: f10:
adds r0, r0, #1 adds r0, r0, #1
adds r0, r0, #1 adds r0, r0, #1
@ check that use of ltorg does not prevent dumping non-empty constant pools at end of section @ check that use of ltorg does not prevent dumping non-empty constant pools at end of section
.section e,"ax",%progbits .section e,"ax",%progbits
@ CHECK-LABEL: f11: @ CHECK-LABEL: f11:
f11: f11:
adds r0, r0, #1 adds r0, r0, #1
adds r0, r0, #1 adds r0, r0, #1
ldr r0, =0x10004 ldr r0, =0x10004
@ CHECK: ldr r0, .Ltmp4 @ CHECK: ldr r0, .Ltmp[[TMP4:[0-9+]]]
b f12 b f12
.ltorg .ltorg
@ constant pool @ constant pool
@ CHECK: .align 2 @ CHECK: .align 2
@ CHECK-LABEL: .Ltmp4: @ CHECK: .Ltmp[[TMP4]]
@ CHECK: .long 65540 @ CHECK: .long 65540
@ CHECK-LABEL: f12: @ CHECK-LABEL: f12:
f12: f12:
adds r0, r0, #1 adds r0, r0, #1
ldr r0, =0x10005 ldr r0, =0x10005
@ CHECK: ldr r0, .Ltmp5 @ CHECK: ldr r0, .Ltmp[[TMP5:[0-9+]]]
.section f,"ax",%progbits .section f,"ax",%progbits
@ CHECK-LABEL: f13 @ CHECK-LABEL: f13
f13: f13:
adds r0, r0, #1 adds r0, r0, #1
adds r0, r0, #1 adds r0, r0, #1
@ should not have a constant pool at end of section with empty constant pools @ should not have a constant pool at end of section with empty constant pools
@ CHECK-NOT: .section a,"ax",%progbits @ CHECK-NOT: .section a,"ax",%progbits
@ CHECK-NOT: .section b,"ax",%progbits @ CHECK-NOT: .section b,"ax",%progbits
@ CHECK-NOT: .section c,"ax",%progbits @ CHECK-NOT: .section c,"ax",%progbits
@ CHECK-NOT: .section d,"ax",%progbits @ CHECK-NOT: .section d,"ax",%progbits
@ should have a non-empty constant pool at end of this section @ should have a non-empty constant pool at end of this section
@ CHECK: .section e,"ax",%progbits @ CHECK: .section e,"ax",%progbits
@ constant pool @ constant pool
@ CHECK: .align 2 @ CHECK: .align 2
@ CHECK-LABEL: .Ltmp5: @ CHECK: .Ltmp[[TMP5]]
@ CHECK: .long 65541 @ CHECK: .long 65541
@ should not have a constant pool at end of section with empty constant pools @ should not have a constant pool at end of section with empty constant pools
@ CHECK-NOT: .section f,"ax",%progbits @ CHECK-NOT: .section f,"ax",%progbits