This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Mark some std::num_get method templates inline

Authored by smeenai on Mar 1 2017, 6:52 PM.



D29157 will make explicit template instantiations expand to default
visibility, at which point these method templates will need to be
explicitly marked hidden visibility to avoid leaking into other DSOs.
Unfortunately, because of clang PR32114, they must be marked inline (in
conjunction with -fvisibility-inlines-hidden) to actually hide them,
since clang doesn't respect the hidden visibility annotation.

Since this involves an ABI change, mark these methods inline in a
separate change, so that the ABI changes can be reviewed separately and
verified to be safe.

Diff Detail


Event Timeline

smeenai created this revision.Mar 1 2017, 6:52 PM
EricWF accepted this revision.Mar 1 2017, 6:56 PM
This revision is now accepted and ready to land.Mar 1 2017, 6:56 PM
This revision was automatically updated to reflect the committed changes.